jasonmolenda wrote:
This is addressing the discussion about the CI failures (and David's repoing of
them) from when I tried to land https://github.com/llvm/llvm-project/pull/96260
.
I had this as a commit for the PR where I'm addressing the CI fails so I can
re-land ( https://github.com/llv
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
lldb-server built with NativeProcessLinux.cpp and NativeProcessFreeBSD.cpp can
use breakpoints to implement instruction stepping on cores where there is no
native instruction-step primitive. Currently
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/108504
lldb-server built with NativeProcessLinux.cpp and NativeProcessFreeBSD.cpp can
use breakpoints to implement instruction stepping on cores where there is no
native instruction-step primitive. Currently the
Author: Jonas Devlieghere
Date: 2024-09-12T22:52:58-07:00
New Revision: 8f653ca135cb8d4f8d08b97cc32a497091f68cdc
URL:
https://github.com/llvm/llvm-project/commit/8f653ca135cb8d4f8d08b97cc32a497091f68cdc
DIFF:
https://github.com/llvm/llvm-project/commit/8f653ca135cb8d4f8d08b97cc32a497091f68cdc.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108498
>From d15881207001934ff83934fae9cdeb52f61eaf6f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Sep 2024 22:43:40 -0700
Subject: [PATCH] [lldb] Emit signpost intervals for progress events (NFC
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108495
>From 734088d8ec84d32304b4f78743999fd561fd4fe3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Sep 2024 22:29:46 -0700
Subject: [PATCH] [lldb] Introduce an always-on system log category/chann
@@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType {
Watchpoints = Log::ChannelFlag<30>,
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
+ AlwaysOn = Log::ChannelFlag<32>,
JDevlieghere wrote:
Yes, definitely. But this code shouldn't ha
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Emit signpost intervals for progress events so that when users report an
operation takes a long time, we can see investigate the issue with Instruments.
---
Full diff: https://github.com/llvm/llvm-p
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108498
Emit signpost intervals for progress events so that when users report an
operation takes a long time, we can see investigate the issue with Instruments.
>From 60096062924d8364e953d8479dcbd4b7ea2faaff Mon S
@@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType {
Watchpoints = Log::ChannelFlag<30>,
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
+ AlwaysOn = Log::ChannelFlag<32>,
jasonmolenda wrote:
does this number need to be unique?
https:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add an "always on" log category and channel. Unlike other, existing log
channels, it is not exposed to users. The channel is meant to be used sparsely
and deliberately for logging high-value informa
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108495
Add an "always on" log category and channel. Unlike other, existing log
channels, it is not exposed to users. The channel is meant to be used sparsely
and deliberately for logging high-value information to
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/7] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/108462
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 approved this pull request.
Now I wish we can feed this kind of information to AI and let AI code review
and catch it :-)
https://github.com/llvm/llvm-project/pull/108462
___
lldb-commits mailing list
lldb-commits@list
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108414
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/5] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/4] Add Progress bar to minidump memory emission
---
.../Minid
jimingham wrote:
> Could you please recommend something to me? If you don't have something
> specific in mind right now, should I look it up and then ask if it is
> suitable to work on before I begin?
The conversion of error handling behaviors was Adrian's project, I haven't
thought about it
AbdAlRahmanGad wrote:
Could you please recommend something to me? If you don't have something
specific in mind right now, should I look it up and then ask if it is suitable
to work on before I begin?
https://github.com/llvm/llvm-project/pull/106831
_
jimingham wrote:
This is more an architectural issue. Right now, we're always handing out
ValueObjectSP's which means there are two ways of indicating failure, having an
empty ValueObjectSP, and having a ValueObjectSP that has a ValueObject in it,
but it's Error state is set. That's pretty a
AbdAlRahmanGad wrote:
As a new contributor, I don't have an opinion on this, but I'm more than happy
to help out with additional tasks whenever needed.
https://github.com/llvm/llvm-project/pull/106831
___
lldb-commits mailing list
lldb-commits@lists.l
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/8] [lldb-dap] Make environment option an object
---
.../tools/l
@@ -175,9 +175,10 @@
"type": "array",
"description": "Additional environment variables to set
when launching the program. E.g. `[\"FOO=1\", \"BAR\"]`",
"items": {
- "type": "string"
+
jimingham wrote:
> > It's funny that there is already a
> > `ValueObject::CreateValueObjectFromBool()` function :-)
>
> The very thing I was worried about!
>
> Might be a good idea to put the general "don't do substantial implementations
> in SB API" principle in the "SBI API" doc page. I did
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/108462.diff
1 Files Affected:
- (modified) lldb/docs/resources/sbapi.rst (+11)
``diff
diff --git a/lldb/docs/resources/sbapi.rst b/lldb/docs/re
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/108462
None
>From f1b503559d9c488b3f2354b836fe5031548b7903 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 12 Sep 2024 15:25:19 -0700
Subject: [PATCH] Add a comment in the SB API doc about keeping the SB API's
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c2b93e0671d8cfd6b1a24c6e1d7be290125b8974...33b647410bacca3e429d1021b8c8ef9ea14ddbe6
lldb
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/6] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
jimingham wrote:
> > You are right, TryAllThreads defaults to True.
> > Not using TryAllThreads is actually dangerous in the general case. For
> > instance, you can have the thread you run take a lock, then call some code
> > that tries another lock that is held by a thread we aren't running. T
jimingham wrote:
> It's funny that there is already a `ValueObject::CreateValueObjectFromBool()`
> function :-)
The very thing I was worried about!
Might be a good idea to put the general "don't do substantial implementations
in SB API" principle in the "SBI API" doc page. I did a quick scan
jeffreytan81 wrote:
> You are right, TryAllThreads defaults to True.
>
> Not using TryAllThreads is actually dangerous in the general case. For
> instance, you can have the thread you run take a lock, then call some code
> that tries another lock that is held by a thread we aren't running. Tha
jimingham wrote:
BTW, I agree that the "run one thread, then run all threads" strategy is
unfortunate. But I can't think of a better way to do that that's likely to be
supported on all platforms. It might be good at some point to add a "Lock
detection plugin" that could provide enough inform
jeffreytan81 wrote:
It's funny that there is already an `ValueObject::CreateValueObjectFromBool()`
function :-)
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108414
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/4] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
jimingham wrote:
You are right, TryAllThreads defaults to True.
Not using TryAllThreads is actually dangerous in the general case. For
instance, you can have the thread you run take a lock, then call some code that
tries another lock that is held by a thread we aren't running. That times o
@@ -686,16 +692,10 @@ Status MinidumpFileBuilder::AddExceptions() {
for (const ThreadSP &thread_sp : thread_list) {
StopInfoSP stop_info_sp = thread_sp->GetStopInfo();
bool add_exception = false;
-if (stop_info_sp) {
- switch (stop_info_sp->GetStopReason()) {
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/5] [lldb-dap] Add feature to remember last non-empty
expression.
jeffreytan81 wrote:
Also, I want to point out that, in this specific example, IRInterpreter will
try to interpret the "(bool)true" expression so it won't run the thread plan
with `TryAllThreads = true`, but I assume you are commenting the danger in a
general sense.
https://github.com/llvm/ll
@@ -1132,6 +1138,8 @@ Status MinidumpFileBuilder::AddMemoryList_64(
error = AddData(data_up->GetBytes(), bytes_read);
if (error.Fail())
return error;
+
+progress.Increment();
clayborg wrote:
Ditto, move before the memory read and add descript
@@ -1024,6 +1027,8 @@ Status MinidumpFileBuilder::AddMemoryList_32(
error = AddData(data_up->GetBytes(), bytes_read);
if (error.Fail())
return error;
+
+progress.Increment();
clayborg wrote:
might be nice to add detail before the ReadMemory a
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/108309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
@jimingham, sounds good. I will move the logic into ValueObject.
> TryAllThreads is true
I did not see any client code setting this to true, I assume this happens
because `m_try_others` is true by default? Maybe we should set `m_try_others`'s
default value to false to avoi
@@ -686,16 +692,10 @@ Status MinidumpFileBuilder::AddExceptions() {
for (const ThreadSP &thread_sp : thread_list) {
StopInfoSP stop_info_sp = thread_sp->GetStopInfo();
bool add_exception = false;
-if (stop_info_sp) {
- switch (stop_info_sp->GetStopReason()) {
@@ -54,6 +54,13 @@ using namespace lldb;
using namespace lldb_private;
using namespace llvm::minidump;
+// Set of all the stop reasons minidumps will collect.
+const std::unordered_set
MinidumpFileBuilder::thread_stop_reasons {
+ lldb::StopReason::eStopReasonException,
+ ll
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
030c6da7af826b641db005be925b20f956c3a6bb...099f017208ddadc07b3743ea7b04612f0f79617f
lldb
Jlalond wrote:
@jeffreytan81 I'll add a test to ensure we get an error message
https://github.com/llvm/llvm-project/pull/108259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From adcc5e8065d2a1b7edf877bd74de9cebd2f84cc9 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 1/3] Create set for the stop reasons we collect, and add
breakpo
https://github.com/jeffreytan81 approved this pull request.
I would suggest we added a unit test that checks that we do get an error
message if saving minidump failed.
Other than that, this looks good.
https://github.com/llvm/llvm-project/pull/108259
__
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 commented:
Can you add a test to check this?
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 030c6da7af826b641db005be925b20f956c3a6bb
030b74c9e763c86d217da39487478e7cf2dff074 --e
@@ -54,6 +54,13 @@ using namespace lldb;
using namespace lldb_private;
using namespace llvm::minidump;
+// Set of all the stop reasons minidumps will collect.
Jlalond wrote:
@labath Hey Pavel, is there a more elegant way to define a constant set? I want
to d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Recently my coworker @jeffreytan81 pointed out that Minidumps don't
show breakpoints when collected. This was prior blocked because Minidumps could
only contain 1 exception, now that we support N signals/sec
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108448
Recently my coworker @jeffreytan81 pointed out that Minidumps don't show
breakpoints when collected. This was prior blocked because Minidumps could only
contain 1 exception, now that we support N signals/sectio
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
+ SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+ ~SaveCoreRequest() {
+if (!m_success)
+ m_builder.DeleteFile();
---
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -191,6 +198,14 @@ def run_test_evaluate_expressions(
self.continue_to_next_stop()
self.assertEvaluate("my_bool_vec", "size=2")
+# Test memory read, especially with 'empty' repeat commands.
+if context == "repl":
+ self.continue_to_ne
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/4] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/5] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
mstorsjo wrote:
I pushed a fix in a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223.
https://github.com/llvm/llvm-project/pull/107968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Martin Storsjö
Date: 2024-09-12T22:26:02+03:00
New Revision: a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223
URL:
https://github.com/llvm/llvm-project/commit/a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223
DIFF:
https://github.com/llvm/llvm-project/commit/a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223.diff
@@ -754,6 +760,7 @@ class Debugger : public
std::enable_shared_from_this,
uint32_t m_interrupt_requested = 0; ///< Tracks interrupt requests
std::mutex m_interrupt_mutex;
+ std::shared_ptr m_telemeter;
oontvoo wrote:
done
https://github.com/llvm/llvm-p
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -191,6 +198,14 @@ def run_test_evaluate_expressions(
self.continue_to_next_stop()
self.assertEvaluate("my_bool_vec", "size=2")
+# Test memory read, especially with 'empty' repeat commands.
+if context == "repl":
+ self.continue_to_ne
vogelsgesang wrote:
Hi @clayborg,
Are you still planning to review this (as requested by @walter-erquinigo)? Or
are you fine with me landing this change without your review?
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing li
https://github.com/vogelsgesang approved this pull request.
Thanks for fixing this! 🙂
https://github.com/llvm/llvm-project/pull/108227
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
vogelsgesang wrote:
Hi @jennphilqc,
Great minds think alike - I actually also implemented the `readMemory` request
in #104317.
Thankfully, we didn't literally do the same, duplicated work
* your PR also implements `writeMemory` which my PR is still lacking. Here your
PR is clearly further al
Michael137 wrote:
> I've fixed the warning with 5d17293caaf0f62ea94fecc137b9b6f07c659dac.
>
>
Thanks!
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/jimingham requested changes to this pull request.
This is good except the implementation should be in ValueObject not SBValue.
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jimingham wrote:
The goal here is excellent! Not only is this a performance problem but if you
call the version of GetValueFromExpression that doesn't take an expression
options - as the code you are replacing does - you get the default value for
"TryAllThreads" - which is `true`. So if you
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 247d3ea843cb20d8d75ec781cd603c8ececf8934
616017152f3f0611462e9863273754036b52f7eb --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
247d3ea843cb20d8d75ec781cd603c8ececf8934...616017152f3f0611462e9863273754036b52f7eb
lldb/
cmtice wrote:
I think I have addressed all the review comments; please take another look.
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -1364,6 +1364,13 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
+ // Remember the last non-empty expression from the user, and
@@ -1363,6 +1363,14 @@ void request_evaluate(const llvm::json::Object &request)
{
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
+ static
cmtice wrote:
> I wrote a fairly long comment on Friday, but I don't see it anymore so, it
> looks like github has swallowed it. Here's my reconstruction of it:
>
> LLDB commands have the notion of a "repeat command", which can sometimes be
> more complicated than just running the same string
@@ -60,7 +60,10 @@ def run_test_evaluate_expressions(
# Expressions at breakpoint 1, which is in main
self.assertEvaluate("var1", "20")
+# Empty expression should equate to the previous expression.
cmtice wrote:
Done
https://github.co
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/3] [lldb-dap] Add feature to remember last non-empty
expression.
vogelsgesang wrote:
Hi @clayborg,
sorry for the late reply - got knocked out by Covid for a while 😷
> Let me know what you think of my idea to always just show the load address of
> any SBValue. I think that is the best for LLDB, but I am open to opinions.
I did check the other lldb-based de
kazutakahirata wrote:
I've fixed the warning with 5d17293caaf0f62ea94fecc137b9b6f07c659dac.
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Author: Kazu Hirata
Date: 2024-09-12T10:43:32-07:00
New Revision: 5d17293caaf0f62ea94fecc137b9b6f07c659dac
URL:
https://github.com/llvm/llvm-project/commit/5d17293caaf0f62ea94fecc137b9b6f07c659dac
DIFF:
https://github.com/llvm/llvm-project/commit/5d17293caaf0f62ea94fecc137b9b6f07c659dac.diff
L
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
+ SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+ ~SaveCoreRequest() {
+if (!m_success)
+ m_builder.DeleteFile();
---
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
jeffreytan81 wrote:
Per our naming convention, let's call this RAII class
`FileRemoveHolder/DumpFailRemoveHolder` or something similar, then the re
kazutakahirata wrote:
> Hmm, this seems to be breaking LLVM build:
>
> ```
> error: initialization of non-aggregate type 'FieldInfo' with a designated
> initializer list
> | FieldInfo this_field_info{.is_bitfield = false};
> ```
FWIW, with clang-16.0.6 as the host compiler, I get:
```
ll
pranavk wrote:
Hmm, this seems to be breaking LLVM build:
```
error: initialization of non-aggregate type 'FieldInfo' with a designated
initializer list
| FieldInfo this_field_info{.is_bitfield = false};
```
https://github.com/llvm/llvm-project/pull/108343
mstorsjo wrote:
> This broke building in mingw configurations, and possibly a few others as
> well.
>
> The `ReportWarning` function takes a pointer to a `std::once_flag`, while
> this is passing it with a `llvm::once_flag`. In many configurations, these
> are the same type, but in a couple o
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108414
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/3] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/4] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/3] Add Progress bar to minidump memory emission
---
.../Minid
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -146,6 +146,8 @@ class LLDB_API SBValue {
lldb::SBValue CreateValueFromData(const char *name, lldb::SBData data,
lldb::SBType type);
+ lldb::SBValue CreateBoolValue(const char *name, bool value);
Jlalond wrote:
I woul
@@ -645,6 +645,33 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
1 - 100 of 143 matches
Mail list logo
