vogelsgesang wrote: Hi @jennphilqc,
Great minds think alike - I actually also implemented the `readMemory` request in #104317. Thankfully, we didn't literally do the same, duplicated work * your PR also implements `writeMemory` which my PR is still lacking. Here your PR is clearly further along * my PR already includes test cases which still seem to be lacking in your PR. When it comes to supporting `readMemory`, my PR seems to be further along Given this, I think we should take the best parts of both PRs 🙂 What do you think about the following path forward? * rebase this PR on top of #104317 * scope this PR down to `writeMemory` * modify this PR to also extend the test cases in `TestDAP_memory.py` (added by my PR) to introduce test coverage also for `writeMemory` ---- Also, I noticed that you did not introduce any `memoryReference`s as part of your pull request. With your PR, how can a user even open the hex-viewer in VS-Code? Is there some way which I am not aware of to open the hex-viewer without a `memoryReference`? Asking, because I was considering introducing a "View memory address" via TypeScript, similar to [what VSCodeLLDB does](https://github.com/vadimcn/codelldb/blob/05502bf75e4e7878a99b0bf0a7a81bba2922cbe3/extension/main.ts#L476) - but if there already is some other way to pop up the memory-viewer, doing so would be unnecessary https://github.com/llvm/llvm-project/pull/108036 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
