mstorsjo wrote:

> This broke building in mingw configurations, and possibly a few others as 
> well.
> 
> The `ReportWarning` function takes a pointer to a `std::once_flag`, while 
> this is passing it with a `llvm::once_flag`. In many configurations, these 
> are the same type, but in a couple ones, they're not.
> 
> LLDB seems to be using a mixture of `std::once_flag` and `llvm::once_flag` 
> throughout, with nontrivial numbers of both, so there's no one obvious 
> preferred way to go here... Or should `ReportWarning` be extended to accept 
> either kinds of flags, until the implementation is settled on either of them?

If there are no suggestions on a way to go here, I'll push a fix within a 
couple hours, that fixes compilation - probably switching the newly added code 
to `std::once_flag` as that's what the existing function takes.

https://github.com/llvm/llvm-project/pull/107968
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to