================
@@ -686,16 +692,10 @@ Status MinidumpFileBuilder::AddExceptions() {
for (const ThreadSP &thread_sp : thread_list) {
StopInfoSP stop_info_sp = thread_sp->GetStopInfo();
bool add_exception = false;
- if (stop_info_sp) {
- switch (stop_info_sp->GetStopReason()) {
- case eStopReasonSignal:
- case eStopReasonException:
+ if (stop_info_sp &&
thread_stop_reasons.count(stop_info_sp->GetStopReason()) > 0) {
add_exception = true;
- break;
- default:
- break;
- }
}
+
----------------
clayborg wrote:
https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-exception_record
The ExceptionCode should be defined it terms of `EXCEPTION_ACCESS_VIOLATION`
and `EXCEPTION_BREAKPOINT` right? We can make up new ExceptionCode values for
LLDB, but they shouldn't interfere with the existing ones. That is unless each
OS can redefine these ExceptionCode values, which might be the case. I would
check the breakpad codebase to see what they do since that is the other major
source of minidump files we consume (breakpad created ones).
https://github.com/llvm/llvm-project/pull/108448
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
