[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These don't need to be ConstStrings. They don't really benefit mu

[Lldb-commits] [lldb] d4c5b45 - [NFC] Remove unneeded semicolon after function definition

Author: Jim Lin Date: 2023-06-07T09:29:49+08:00 New Revision: d4c5b452934a31f9b3685cf58bd682104b686d1a URL: https://github.com/llvm/llvm-project/commit/d4c5b452934a31f9b3685cf58bd682104b686d1a DIFF: https://github.com/llvm/llvm-project/commit/d4c5b452934a31f9b3685cf58bd682104b686d1a.diff LOG:

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152326/new/ https://reviews.llvm.org/D152326 ___

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

bulbazord created this revision. bulbazord added reviewers: wallace, jj10306, persona0220. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The way it works now, it stores a `const char *` that it does

[Lldb-commits] [PATCH] D152319: [lldb] Run crashlog inside lldb when invoked in interactive mode from the command line

mib accepted this revision. mib added a comment. LGTM! Thanks for taking care of this :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152319/new/ https://reviews.llvm.org/D152319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

mib added a comment. > Could you take a look? If it takes some time to fix, could you revert this > change please? @haowei bcfd85a25857294cb4a5cfa3f616f57a6911cda6 should fix the test failure. Let me know if there is another

[Lldb-commits] [lldb] bcfd85a - [lldb/test] Fix target-label.test on Fuchsia

Author: Med Ismail Bennani Date: 2023-06-06T17:42:09-07:00 New Revision: bcfd85a25857294cb4a5cfa3f616f57a6911cda6 URL: https://github.com/llvm/llvm-project/commit/bcfd85a25857294cb4a5cfa3f616f57a6911cda6 DIFF: https://github.com/llvm/llvm-project/commit/bcfd85a25857294cb4a5cfa3f616f57a6911cda6.

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, Michael137, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These don't really need to be in the ConstString

[Lldb-commits] [PATCH] D152319: [lldb] Run crashlog inside lldb when invoked in interactive mode from the command line

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is super convenient! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152319/new/ https://reviews.llvm.org/D152319 ___ lldb-co

[Lldb-commits] [PATCH] D152319: [lldb] Run crashlog inside lldb when invoked in interactive mode from the command line

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Run crashlog inside lldb when invoked in interactive mode from the command line. Currently, when passing -i to crashlog from the command lin

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

haowei added a comment. Hi The `lldb-shell :: Target/target-label.test` is broken on our LLVM builder after this change was landed. Error message we saw: Script: -- : 'RUN: at line 1'; /b/s/w/ir/x/w/staging/llvm_build/bin/lldb --no-lldbinit -S /b/s/w/ir/x/w/staging/llvm_build/tools/lld

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

bulbazord updated this revision to Diff 529081. bulbazord added a comment. Minor pedantry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/new/ https://reviews.llvm.org/D152315 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/source/Plu

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

aprantl added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:868 +lldb::BasicType TypeSystemClang::GetBasicTypeEnumeration(llvm::StringRef name) { + if (name.empty()) +return eBasicTypeInvalid; bulbazord wrote: > apran

[Lldb-commits] [lldb] 431f082 - [lldb] Disable some tests on windows

Author: Med Ismail Bennani Date: 2023-06-06T16:10:05-07:00 New Revision: 431f082a55488b12ae12d4330b6c6c61dc3e61be URL: https://github.com/llvm/llvm-project/commit/431f082a55488b12ae12d4330b6c6c61dc3e61be DIFF: https://github.com/llvm/llvm-project/commit/431f082a55488b12ae12d4330b6c6c61dc3e61be.

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

bulbazord added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:868 +lldb::BasicType TypeSystemClang::GetBasicTypeEnumeration(llvm::StringRef name) { + if (name.empty()) +return eBasicTypeInvalid; aprantl wrote: > Isn't

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:868 +lldb::BasicType TypeSystemClang::GetBasicTypeEnumeration(llvm::StringRef name) { + if (name.

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord updated this revision to Diff 529069. bulbazord added a comment. `llvm::StringRef` -> `const std::string &` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://reviews.llvm.org/D152220 Files: lldb/include/lldb/Utility/Bro

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, fdeazeve, Michael137, augusto2112, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `TypeSystemClang::Get

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/Broadcaster.h:358-360 +llvm::StringRef GetBroadcasterName() const { + return m_broadcaster.GetBroadcasterName(); } JDevlieghere wrote: > Why not return a `const std::string &` he

[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152310/new/ https://reviews.llvm.org/D152310 ___

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline question. Comment at: lldb/include/lldb/Utility/Broadcaster.h:358-360 +llvm::StringRef GetBroadcasterName() const { + return m_broadca

[Lldb-commits] [lldb] a10019a - [lldb] Fix "NameError: name 'self' is not defined" when using crashlog -c

Author: Jonas Devlieghere Date: 2023-06-06T15:20:53-07:00 New Revision: a10019a496d420769d7aae94f234ab6cf9fd778d URL: https://github.com/llvm/llvm-project/commit/a10019a496d420769d7aae94f234ab6cf9fd778d DIFF: https://github.com/llvm/llvm-project/commit/a10019a496d420769d7aae94f234ab6cf9fd778d.d

[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString is simply not needed here. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord updated this revision to Diff 529031. bulbazord added a comment. LLDB_LOGF -> LLDB_LOG where needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://reviews.llvm.org/D152220 Files: lldb/include/lldb/Utility/Broadcaster

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord updated this revision to Diff 529029. bulbazord added a comment. Address @JDevlieghere's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://reviews.llvm.org/D152220 Files: lldb/include/lldb/Utility/Broadcaster.h

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd1d4231a7c: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] 7cd1d42 - [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

Author: Jonas Devlieghere Date: 2023-06-06T13:02:43-07:00 New Revision: 7cd1d4231a7c83e719b83c6abbe2d479baa03808 URL: https://github.com/llvm/llvm-project/commit/7cd1d4231a7c83e719b83c6abbe2d479baa03808 DIFF: https://github.com/llvm/llvm-project/commit/7cd1d4231a7c83e719b83c6abbe2d479baa03808.d

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG6099d519bb83: [lldb] Support file and function names in LLDB_LOGF macro (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 6099d51 - [lldb] Support file and function names in LLDB_LOGF macro

Author: Jonas Devlieghere Date: 2023-06-06T12:24:38-07:00 New Revision: 6099d519bb83cc0b97ce8b529743f832de144110 URL: https://github.com/llvm/llvm-project/commit/6099d519bb83cc0b97ce8b529743f832de144110 DIFF: https://github.com/llvm/llvm-project/commit/6099d519bb83cc0b97ce8b529743f832de144110.d

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 +// argument. +// As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111. +auto *SNTTPE = cast(E); bolshakov-a wrote: > efriedma wrote: > > bolshakov-a w

[Lldb-commits] [PATCH] D152013: [lldb/Commands] Fix disk completion from root directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8966125e281: [lldb/Commands] Fix disk completion from root directory (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D152012: [lldb/crashlog] Expand crash report file path before parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bc0baf9d439: [lldb/crashlog] Expand crash report file path before parsing (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152012/new/ http

[Lldb-commits] [lldb] 3bc0baf - [lldb/crashlog] Expand crash report file path before parsing

Author: Med Ismail Bennani Date: 2023-06-06T10:58:34-07:00 New Revision: 3bc0baf9d43967d828e2d311f6c0863e79158f07 URL: https://github.com/llvm/llvm-project/commit/3bc0baf9d43967d828e2d311f6c0863e79158f07 DIFF: https://github.com/llvm/llvm-project/commit/3bc0baf9d43967d828e2d311f6c0863e79158f07.

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a9c3e611505: [lldb/Commands] Add support to auto-completion for user commands (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152011/new/

[Lldb-commits] [lldb] e896612 - [lldb/Commands] Fix disk completion from root directory

Author: Med Ismail Bennani Date: 2023-06-06T10:58:34-07:00 New Revision: e8966125e2812f08bf0f548bf576981025d44cbd URL: https://github.com/llvm/llvm-project/commit/e8966125e2812f08bf0f548bf576981025d44cbd DIFF: https://github.com/llvm/llvm-project/commit/e8966125e2812f08bf0f548bf576981025d44cbd.

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

This revision was automatically updated to reflect the committed changes. mib marked 2 inline comments as done. Closed by commit rG1e82b20118e3: [lldb/Target] Add ability to set a label to targets (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 1e82b20 - [lldb/Target] Add ability to set a label to targets

Author: Med Ismail Bennani Date: 2023-06-06T10:58:34-07:00 New Revision: 1e82b20118e31bd6c3844a84e03f701997a9b7ed URL: https://github.com/llvm/llvm-project/commit/1e82b20118e31bd6c3844a84e03f701997a9b7ed DIFF: https://github.com/llvm/llvm-project/commit/1e82b20118e31bd6c3844a84e03f701997a9b7ed.

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. This is really cool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152011/new/ https://reviews.llvm.org/D152011 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/Broadcaster.h:157 + /// A StringRef of the name that this broadcaster will have. + Broadcaster(lldb::Broad

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

mib updated this revision to Diff 528928. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152011/new/ https://reviews.llvm.org/D152011 Files: lldb/docs/python_api_enums.rst lldb/examples/python/c

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:1279 + // if you & in this bit the base code will not process the option. + eCustomCompletion = (1u << 24) +}; JDevlieghere wrote: > Should this b

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

rupprecht added a subscriber: labath. rupprecht added a comment. The other tricky part I missed before is this bit in between pulling the event off the listener queue and deciding to show it: auto *data = ProgressEventData::GetEventDataFromEvent(event_sp.get()); if (!data) return; /

[Lldb-commits] [lldb] cb9a7c2 - [LLDB][PDB] Fix age field in UUID in PDB file.

Author: Zequan Wu Date: 2023-06-06T11:24:50-04:00 New Revision: cb9a7c22ee6789569e28dde073e6827761b4d003 URL: https://github.com/llvm/llvm-project/commit/cb9a7c22ee6789569e28dde073e6827761b4d003 DIFF: https://github.com/llvm/llvm-project/commit/cb9a7c22ee6789569e28dde073e6827761b4d003.diff LOG

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9a7c22ee67: [LLDB][PDB] Fix age field in UUID in PDB file. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152189/new/ https://revie

[Lldb-commits] [PATCH] D152225: [lldb] fix dangling reference in `ClangHost.cpp`

aprantl added a comment. Thanks! FWIW, it seems like an unnecessary micro optimization to make both these variables static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152225/new/ https://reviews.llvm.org/D152225 __

[Lldb-commits] [PATCH] D152225: [lldb] fix dangling reference in `ClangHost.cpp`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c02e365711c: [lldb] fix dangling reference in `ClangHost.cpp` (authored by paperchalice, committed by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 6c02e36 - [lldb] fix dangling reference in `ClangHost.cpp`

Author: paperchalice Date: 2023-06-06T08:11:01-07:00 New Revision: 6c02e365711cab47ed9abe9f091c25651a3efd74 URL: https://github.com/llvm/llvm-project/commit/6c02e365711cab47ed9abe9f091c25651a3efd74 DIFF: https://github.com/llvm/llvm-project/commit/6c02e365711cab47ed9abe9f091c25651a3efd74.diff

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

saugustine added a comment. In D150805#4397940 , @rupprecht wrote: > In D150805#4350849 , @JDevlieghere > wrote: > >> I also like Jordan's rate limiting idea. In my mind that should be a >> property of the broad

[Lldb-commits] [PATCH] D152225: [lldb] fix dangling reference in `ClangHost.cpp`

paperchalice added a comment. If this patch fixes the CI failure , I need someone to commit this change, thanks in advance. Repo