bulbazord added inline comments.
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:868
+lldb::BasicType TypeSystemClang::GetBasicTypeEnumeration(llvm::StringRef name)
{
+ if (name.empty())
+ return eBasicTypeInvalid;
----------------
aprantl wrote:
> Isn't this redundant?
Technically yes. My reasoning is that it's faster to see if a StringRef is
empty than to perform a lookup in a hash map.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152315/new/
https://reviews.llvm.org/D152315
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
