bulbazord added inline comments.
================
Comment at: lldb/include/lldb/Utility/Broadcaster.h:358-360
+ llvm::StringRef GetBroadcasterName() const {
+ return m_broadcaster.GetBroadcasterName();
}
----------------
JDevlieghere wrote:
> Why not return a `const std::string &` here or, alternatively, why not return
> a StringRef above?
Good question. IMO it'd be nice to return a StringRef here but it's probably
more practical to return a `const std::string &` here since we often pass it to
printf-style formatters for logging (which, for StringRef, you'd need to do
`ref.str().c_str()` to do it safely).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152220/new/
https://reviews.llvm.org/D152220
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
