[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

[Alex Langford via Phabricator via lldb-commits]

bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib, jingham.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

ConstString is simply not needed here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152310

Files:
  lldb/source/Interpreter/OptionValueLanguage.cpp


Index: lldb/source/Interpreter/OptionValueLanguage.cpp
===================================================================
--- lldb/source/Interpreter/OptionValueLanguage.cpp
+++ lldb/source/Interpreter/OptionValueLanguage.cpp
@@ -43,10 +43,8 @@
 
   case eVarSetOperationReplace:
   case eVarSetOperationAssign: {
-    ConstString lang_name(value.trim());
     LanguageSet languages_for_types = 
Language::GetLanguagesSupportingTypeSystems();
-    LanguageType new_type =
-        Language::GetLanguageTypeFromString(lang_name.GetStringRef());
+    LanguageType new_type = Language::GetLanguageTypeFromString(value.trim());
     if (new_type && languages_for_types[new_type]) {
       m_value_was_set = true;
       m_current_value = new_type;



Index: lldb/source/Interpreter/OptionValueLanguage.cpp
===================================================================
--- lldb/source/Interpreter/OptionValueLanguage.cpp
+++ lldb/source/Interpreter/OptionValueLanguage.cpp
@@ -43,10 +43,8 @@
 
   case eVarSetOperationReplace:
   case eVarSetOperationAssign: {
-    ConstString lang_name(value.trim());
     LanguageSet languages_for_types = Language::GetLanguagesSupportingTypeSystems();
-    LanguageType new_type =
-        Language::GetLanguageTypeFromString(lang_name.GetStringRef());
+    LanguageType new_type = Language::GetLanguageTypeFromString(value.trim());
     if (new_type && languages_for_types[new_type]) {
       m_value_was_set = true;
       m_current_value = new_type;

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits