[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM modulo inline question.



================
Comment at: lldb/include/lldb/Utility/Broadcaster.h:358-360
+    llvm::StringRef GetBroadcasterName() const {
+      return m_broadcaster.GetBroadcasterName();
     }
----------------
Why not return a `const std::string &` here or, alternatively, why not return a 
StringRef above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152220/new/

https://reviews.llvm.org/D152220

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits