[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

labath added a comment. In D90876#2377544 , @mgorny wrote: > In D90876#2377541 , @emaste wrote: > >> How does Windows fit into this? Other than that Q, LGTM. > > @labath, any clue? I don't know... Since the test is

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negatives in llgs/debugserver logic

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:950 +configuration.llgs_platform = ( +target_platform in ["linux", "freebsd", "netbsd", "windows"])

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:183 + /// llvm::Error::success() otherwise. + virtual llvm::Error StopTracingThread(const Thread &thread) { +return llvm::make_error(); clayborg wrote: > We need to have StartTr

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace updated this revision to Diff 303313. wallace marked 5 inline comments as done. wallace added a comment. Address all comments, specially improved the documentation requested by @clayborg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90490/

[Lldb-commits] [lldb] cfd96f0 - [trace][intel-pt] Implement the basic decoding functionality

Author: Walter Erquinigo Date: 2020-11-05T18:38:03-08:00 New Revision: cfd96f057ba4256fef49518cad43d0a7f591da12 URL: https://github.com/llvm/llvm-project/commit/cfd96f057ba4256fef49518cad43d0a7f591da12 DIFF: https://github.com/llvm/llvm-project/commit/cfd96f057ba4256fef49518cad43d0a7f591da12.di

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfd96f057ba4: [trace][intel-pt] Implement the basic decoding functionality (authored by Walter Erquinigo , committed by wallace). R

[Lldb-commits] [lldb] 99a99c2 - [lldb] Remove Crashlog/interactive.test

Author: Jonas Devlieghere Date: 2020-11-05T17:10:52-08:00 New Revision: 99a99c29c6daef56a320a0d77bb6691aa66d81f1 URL: https://github.com/llvm/llvm-project/commit/99a99c29c6daef56a320a0d77bb6691aa66d81f1 DIFF: https://github.com/llvm/llvm-project/commit/99a99c29c6daef56a320a0d77bb6691aa66d81f1.d

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/Trace.h:183 + /// llvm::Error::success() otherwise. + virtual llvm::Error StopTracingThread(const Thread &thread)

[Lldb-commits] [PATCH] D90895: [TargetList] Delete the destructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65d15fefe339: [TargetList] Delete the destructor (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] 65d15fe - [TargetList] Delete the destructor

Author: Vedant Kumar Date: 2020-11-05T16:56:37-08:00 New Revision: 65d15fefe3392b1db2f679b3df029d43d8d26d2d URL: https://github.com/llvm/llvm-project/commit/65d15fefe3392b1db2f679b3df029d43d8d26d2d DIFF: https://github.com/llvm/llvm-project/commit/65d15fefe3392b1db2f679b3df029d43d8d26d2d.diff

[Lldb-commits] [PATCH] D90895: [TargetList] Delete the destructor

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90895/new/ https://reviews.llvm.org/D90895 _

[Lldb-commits] [PATCH] D90895: [TargetList] Delete the destructor

vsk created this revision. vsk added reviewers: teemperor, JDevlieghere, jingham. Herald added a project: LLDB. vsk requested review of this revision. AFAICT, ~TargetList simply implements the default destructor, plus some locking. The history is murky, so I'm not sure why we do this locking. Per

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

clayborg added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:248 +// { +//"name": +//"description": Should this specify that this name needs to match the name of the LLDB plug-in? Comment at: lldb/include/lldb/Utility/St

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16e5a347e70b: [TargetList] Simplify dummy target creation (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D90872?vs=303252&id

[Lldb-commits] [lldb] 16e5a34 - [TargetList] Simplify dummy target creation

Author: Vedant Kumar Date: 2020-11-05T16:04:02-08:00 New Revision: 16e5a347e70b4c819ff4402320457cc2c8ca URL: https://github.com/llvm/llvm-project/commit/16e5a347e70b4c819ff4402320457cc2c8ca DIFF: https://github.com/llvm/llvm-project/commit/16e5a347e70b4c819ff4402320457cc2c8ca.diff

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I am good too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 ___

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

mgorny added a comment. In D90876#2377541 , @emaste wrote: > How does Windows fit into this? Other than that Q, LGTM. @labath, any clue? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 _

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

emaste added a comment. How does Windows fit into this? Other than that Q, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

vsk added inline comments. Comment at: lldb/source/Core/Debugger.cpp:685 - m_dummy_target_sp = m_target_list.GetDummyTarget(*this); + { +ArchSpec arch(Target::GetDefaultArchitecture()); teemperor wrote: > Maybe have a small comment here that summarizes th

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:692 +m_dummy_target_sp.reset( +new Target(*this, arch, default_platform_sp, is_dummy_target)); + } Should we move all this into `Target` and have a private static `TargetSP

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Core/Debugger.cpp:685 - m_dummy_target_sp = m_target_list.GetDummyTarget(*this); + { +ArchSpec arch(Target::GetDefaultArchitecture

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

jingham added a comment. Oh, my bad, apparently we were leaving the dummy target out of the TargetList. That's a little odd, but I probably did it so that's not so unusual... Ignore my comments... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

vsk added inline comments. Comment at: lldb/source/Target/TargetList.cpp:293 // FIXME: Maybe the dummy target should be per-Debugger - if (!m_dummy_target_sp || !m_dummy_target_sp->IsValid()) { + if (!m_dummy_target_sp) { ArchSpec arch(Target::GetDefaultArchitecture());

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

jingham added inline comments. Comment at: lldb/source/Target/TargetList.cpp:293 // FIXME: Maybe the dummy target should be per-Debugger - if (!m_dummy_target_sp || !m_dummy_target_sp->IsValid()) { + if (!m_dummy_target_sp) { ArchSpec arch(Target::GetDefaultArchitecture

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

vsk updated this revision to Diff 303252. vsk marked an inline comment as done. vsk added a comment. Make the dummy target per-debugger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90872/new/ https://reviews.llvm.org/D90872 Files: lldb/include

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/source/Target/TargetList.cpp:293 // FIXME: Maybe the dummy target should be per-Debugger - if (!m_dummy_target_sp || !m_dummy_target_sp->IsValid()) { + if (!m_dummy_target_sp) { ArchSpec a

[Lldb-commits] [lldb] ca17571 - [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

Author: Pedro Tammela Date: 2020-11-05T21:23:20Z New Revision: ca17571051d4e0a63e702371984dbd3671261f79 URL: https://github.com/llvm/llvm-project/commit/ca17571051d4e0a63e702371984dbd3671261f79 DIFF: https://github.com/llvm/llvm-project/commit/ca17571051d4e0a63e702371984dbd3671261f79.diff LOG:

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca17571051d4: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout' (authored by tammela). Changed prior to commit: https://reviews.llvm.org/D907

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

JDevlieghere added inline comments. Comment at: lldb/source/Target/TargetList.cpp:293 // FIXME: Maybe the dummy target should be per-Debugger - if (!m_dummy_target_sp || !m_dummy_target_sp->IsValid()) { + if (!m_dummy_target_sp) { ArchSpec arch(Target::GetDefaultArchite

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Make the comment indicate more strongly that this behavior is Darwin-specific and it is not a bug for other platforms to behave differently. https://reviews.llvm.org/D9087

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negatives in llgs/debugserver logic

mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:953 +# Perform debugserver tests on Darwin platforms. Currently, this +# means all platform that do not use LLGS but additional platforms +# may be excluded in the future. ---

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negatives in llgs/debugserver logic

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Use positive logic (i.e. llgs_platform/debugserver_platform) for indicating which platforms use the particular server variant. Deduplicate the lists — it is rather expected

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

vsk updated this revision to Diff 303223. vsk added a comment. Delete some dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90872/new/ https://reviews.llvm.org/D90872 Files: lldb/include/lldb/Target/TargetList.h lldb/source/Target/Targ

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

vsk created this revision. vsk added reviewers: teemperor, JDevlieghere, jingham. Herald added a project: LLDB. vsk requested review of this revision. Factor out dummy target creation from CreateTargetInternal. This makes it impossible for dummy target creation to accidentally fail due to too-str

[Lldb-commits] [PATCH] D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching

This revision was automatically updated to reflect the committed changes. Closed by commit rG40140e122f8b: [lldb] [Process/FreeBSDRemote] Remove thread name caching (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] 40140e1 - [lldb] [Process/FreeBSDRemote] Remove thread name caching

Author: Michał Górny Date: 2020-11-05T20:45:34+01:00 New Revision: 40140e122f8b6512ebe22efc32dacf14f10117f6 URL: https://github.com/llvm/llvm-project/commit/40140e122f8b6512ebe22efc32dacf14f10117f6 DIFF: https://github.com/llvm/llvm-project/commit/40140e122f8b6512ebe22efc32dacf14f10117f6.diff

[Lldb-commits] [PATCH] D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGb643deb03fb9: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] b643deb - [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

Author: Michał Górny Date: 2020-11-05T20:45:34+01:00 New Revision: b643deb03fb935d414f74e07b702ebb4e5c33bf3 URL: https://github.com/llvm/llvm-project/commit/b643deb03fb935d414f74e07b702ebb4e5c33bf3 DIFF: https://github.com/llvm/llvm-project/commit/b643deb03fb935d414f74e07b702ebb4e5c33bf3.diff

[Lldb-commits] [PATCH] D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching

mgorny added a comment. In D90863#2376742 , @emaste wrote: > Does Linux fetch each time also? > I agree it's probably not worth the effort. Yes. However, their logic is simpler (it boils down to opening a dedicated file in procfs (i.e. they don't have to

[Lldb-commits] [PATCH] D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching

emaste added a comment. Does Linux fetch each time also? I agree it's probably not worth the effort. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90863/new/ https://reviews.llvm.org/D90863 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

sgraenitz added a comment. Thanks for having a look! The JIT implementations in LLVM operate on relocatable object files, so someone needs to resolve them. MCJIT has a flag `ProcessAllSections` to control which sections will be loaded and relocated. As it is off by default, it will usually ign

[Lldb-commits] [PATCH] D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

mgorny added a comment. Note that D90863 is also required to fix the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90862/new/ https://reviews.llvm.org/D90862 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching

mgorny created this revision. mgorny added reviewers: krytarowski, emaste, labath. Herald added a reviewer: JDevlieghere. mgorny requested review of this revision. Remove the thread name caching code. It does not handle the possibility of thread name changing between requests, therefore breaking

[Lldb-commits] [PATCH] D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a reviewer: JDevlieghere. mgorny requested review of this revision. Fix TestGdbRemoteThreadName to call ::pthread_setname_np instead of ::pthread_set_name_np on F

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG2c2eb5e6702b: [lldb] Enable FreeBSDRemote plugin by default and update test status (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] 2c2eb5e - [lldb] Enable FreeBSDRemote plugin by default and update test status

Author: Michał Górny Date: 2020-11-05T17:49:46+01:00 New Revision: 2c2eb5e6702bf3bbb8fb8f09790b1ab7b139e879 URL: https://github.com/llvm/llvm-project/commit/2c2eb5e6702bf3bbb8fb8f09790b1ab7b139e879 DIFF: https://github.com/llvm/llvm-project/commit/2c2eb5e6702bf3bbb8fb8f09790b1ab7b139e879.diff

[Lldb-commits] [lldb] 6ba2c2b - [lldb] [test/Shell] Simplify -pthread condition

Author: Michał Górny Date: 2020-11-05T17:49:20+01:00 New Revision: 6ba2c2bf90f23381c1d052acb010cee364bebe8e URL: https://github.com/llvm/llvm-project/commit/6ba2c2bf90f23381c1d052acb010cee364bebe8e DIFF: https://github.com/llvm/llvm-project/commit/6ba2c2bf90f23381c1d052acb010cee364bebe8e.diff

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90787/new/ https://reviews.llvm.org/D90787 _

[Lldb-commits] [lldb] 79d1676 - [lldb][NFC] Fix compiler warnings after removal of eValueTypeVector

Author: Raphael Isemann Date: 2020-11-05T17:17:33+01:00 New Revision: 79d16764dd29aeddb7e6400e6b2d89d31653886c URL: https://github.com/llvm/llvm-project/commit/79d16764dd29aeddb7e6400e6b2d89d31653886c DIFF: https://github.com/llvm/llvm-project/commit/79d16764dd29aeddb7e6400e6b2d89d31653886c.dif

[Lldb-commits] [lldb] b9b5f12 - [lldb] Set the default architecture also in buildDefault

Author: Raphael Isemann Date: 2020-11-05T16:32:05+01:00 New Revision: b9b5f12bd4cd0647ff630c1631e0cf20f430fa15 URL: https://github.com/llvm/llvm-project/commit/b9b5f12bd4cd0647ff630c1631e0cf20f430fa15 DIFF: https://github.com/llvm/llvm-project/commit/b9b5f12bd4cd0647ff630c1631e0cf20f430fa15.dif

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:955 -# Don't do lldb-server (llgs) tests on anything except Linux and Windows. +# Don't do lldb-server (llgs) tests on platforms not supporting it. configuration.dont_do_llgs_te

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste accepted this revision. emaste added a comment. > What do you suggest? Is it fine to go with my results for as long as I work > on it? I can update it to match CI/buildbot results later. Yes absolutely. I pasted my results mainly as an FYI/for comparison, since I recall there were many i

[Lldb-commits] [lldb] 26a8e85 - [lldb] Add Apple simulator platforms to lldbplatform.py

Author: Raphael Isemann Date: 2020-11-05T15:34:42+01:00 New Revision: 26a8e8502b5943cc13177bea48841491dadfef9b URL: https://github.com/llvm/llvm-project/commit/26a8e8502b5943cc13177bea48841491dadfef9b DIFF: https://github.com/llvm/llvm-project/commit/26a8e8502b5943cc13177bea48841491dadfef9b.dif

[Lldb-commits] [PATCH] D89694: [lldb] Add Apple simulator platforms to lldbplatform.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG26a8e8502b59: [lldb] Add Apple simulator platforms to lldbplatform.py (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] d68ebea - Reland [lldb] Explicitly use the configuration architecture when building test executables

Author: Raphael Isemann Date: 2020-11-05T15:13:48+01:00 New Revision: d68ebea7670f6bbba136f1517a1cff3696b6a800 URL: https://github.com/llvm/llvm-project/commit/d68ebea7670f6bbba136f1517a1cff3696b6a800 DIFF: https://github.com/llvm/llvm-project/commit/d68ebea7670f6bbba136f1517a1cff3696b6a800.dif

[Lldb-commits] [PATCH] D89695: [lldb] Skip TestChangeProcessGroup on watchOS/tvOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG239f488fd692: [lldb] Skip TestChangeProcessGroup on watchOS/tvOS (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [lldb] 239f488 - [lldb] Skip TestChangeProcessGroup on watchOS/tvOS

Author: Raphael Isemann Date: 2020-11-05T15:11:30+01:00 New Revision: 239f488fd692f2af506b2b45d335404d0d2ab30b URL: https://github.com/llvm/llvm-project/commit/239f488fd692f2af506b2b45d335404d0d2ab30b DIFF: https://github.com/llvm/llvm-project/commit/239f488fd692f2af506b2b45d335404d0d2ab30b.dif

[Lldb-commits] [PATCH] D89302: [lldb] Also Catch invalid calls to TestPExpectTest's expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f84b59a4cf9: [lldb] Also Catch invalid calls to TestPExpectTest's expect() (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] 2f84b59 - [lldb] Also Catch invalid calls to TestPExpectTest's expect()

Author: Raphael Isemann Date: 2020-11-05T14:08:46+01:00 New Revision: 2f84b59a4cf92a0ce1b985e7f44e17483efa33c0 URL: https://github.com/llvm/llvm-project/commit/2f84b59a4cf92a0ce1b985e7f44e17483efa33c0 DIFF: https://github.com/llvm/llvm-project/commit/2f84b59a4cf92a0ce1b985e7f44e17483efa33c0.dif

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

tammela updated this revision to Diff 303088. tammela added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90787/new/ https://reviews.llvm.org/D90787 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/source/

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

labath added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:945 + auto to_generic = [addr_size = opcodes.GetAddressByteSize()](auto v) { +bool is_signed = std::is_signed::value; +return Scalar( This is probably not conforming eit

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

labath created this revision. labath added reviewers: JDevlieghere, aprantl, dblaikie. Herald added a project: LLDB. labath requested review of this revision. Dwarf says (Section 2.5.1.1. of DWARF v5) that these operations should push "generic" (pointer-sized) values. This was not the case for DW_

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:32 @skipIfWindows # the test is not updated for Windows. +@expectedFailureAll(oslist=["freebsd"]) @llgs_test --

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems reasonable to me. I do wonder though if the jit could be changed to avoid relocation. I don't know what's the behavior of other JITs, but given that the jitted object is not going to ge

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 303052. omjavaid added a comment. This updates after discussion yesterday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp l

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2373557 , @labath wrote: > [ I've replying to your message in a slightly different order that what it > was written. ] > > In D82863#2373356 , @omjavaid wrote: > >> In D82863#237