mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste.
Herald added a subscriber: arichardson.
Herald added a reviewer: JDevlieghere.
mgorny requested review of this revision.
Fix TestGdbRemoteThreadName to call ::pthread_setname_np instead
of ::pthread_set_name_np on FreeBSD. While technically both names
are correct, the former is preferable because of compatibility
with Linux. Furthermore, the latter requires `#include <pthread_np.h>`
that was missing causing the test to fail to compile.
https://reviews.llvm.org/D90862
Files:
lldb/test/API/tools/lldb-server/thread-name/main.cpp
Index: lldb/test/API/tools/lldb-server/thread-name/main.cpp
===================================================================
--- lldb/test/API/tools/lldb-server/thread-name/main.cpp
+++ lldb/test/API/tools/lldb-server/thread-name/main.cpp
@@ -4,9 +4,7 @@
void set_thread_name(const char *name) {
#if defined(__APPLE__)
::pthread_setname_np(name);
-#elif defined(__FreeBSD__)
- ::pthread_set_name_np(::pthread_self(), name);
-#elif defined(__linux__)
+#elif defined(__FreeBSD__) || defined(__linux__)
::pthread_setname_np(::pthread_self(), name);
#elif defined(__NetBSD__)
::pthread_setname_np(::pthread_self(), "%s", const_cast<char *>(name));
Index: lldb/test/API/tools/lldb-server/thread-name/main.cpp
===================================================================
--- lldb/test/API/tools/lldb-server/thread-name/main.cpp
+++ lldb/test/API/tools/lldb-server/thread-name/main.cpp
@@ -4,9 +4,7 @@
void set_thread_name(const char *name) {
#if defined(__APPLE__)
::pthread_setname_np(name);
-#elif defined(__FreeBSD__)
- ::pthread_set_name_np(::pthread_self(), name);
-#elif defined(__linux__)
+#elif defined(__FreeBSD__) || defined(__linux__)
::pthread_setname_np(::pthread_self(), name);
#elif defined(__NetBSD__)
::pthread_setname_np(::pthread_self(), "%s", const_cast<char *>(name));
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
