JDevlieghere added inline comments.
================
Comment at: lldb/source/Target/TargetList.cpp:293
// FIXME: Maybe the dummy target should be per-Debugger
- if (!m_dummy_target_sp || !m_dummy_target_sp->IsValid()) {
+ if (!m_dummy_target_sp) {
ArchSpec arch(Target::GetDefaultArchitecture());
----------------
I wonder if we gain anything by making this lazy. Maybe it's time to address
that FIXME and always have a single DummyTarget held onto by the Debugger?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90872/new/
https://reviews.llvm.org/D90872
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
