mgorny marked 2 inline comments as done.
mgorny added inline comments.

================
Comment at: 
lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:32
     @skipIfWindows # the test is not updated for Windows.
+    @expectedFailureAll(oslist=["freebsd"])
     @llgs_test
----------------
labath wrote:
> mgorny wrote:
> > labath wrote:
> > > What's up with this? I though you fixed thread names already..
> > The test code is buggy. I want to fix it separately not to mix things up 
> > too much.
> Fixing it here is not a good idea, yes. But I think it would have been good 
> to fix in the patch that was implementing thread name support.
I'm planning to run the test suite a lot more once this lands, and we have more 
predictable results.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90757/new/

https://reviews.llvm.org/D90757

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to