labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:950 + configuration.llgs_platform = ( + target_platform in ["linux", "freebsd", "netbsd", "windows"]) + ---------------- This is not entirely equivalent to the previous version -- it won't match "platforms" like "freebsd4.7". Fortunately, we already have some canonicalization code in `lldbplatformutil.getPlatform()`, so if you switch to that, it should be fine. ================ Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:953 + # Perform debugserver tests on Darwin platforms. Currently, this + # means all platform that do not use LLGS but additional platforms + # may be excluded in the future. ---------------- mgorny wrote: > @labath, can we assume that all future platforms will use LLGS? I certainly hope so. I doubt anyone would port debugserver to another os, and I definitely would not want to carry another debugserver around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90875/new/ https://reviews.llvm.org/D90875 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
