[Kmymoney-devel] [kmymoney4] [Bug 327374] problems while getting bank details by HBCI

2013-11-11 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=327374 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #1 from

[Kmymoney-devel] [kmymoney4] [Bug 313237] No payee matching with aqbanking import (HBCI)

2013-12-07 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=313237 --- Comment #10 from Christian David --- Git commit c836c3dec4509fb229cf2f71e31afe23512dac4e by Christian Dávid. Committed on 07/12/2013 at 17:02. Pushed by christiand into branch 'add-onlinebanking'. Started adding onlinebanking includi

[Kmymoney-devel] [kmymoney4] [Bug 238105] Support for money transfers and chip card readers for authentication

2013-12-07 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=238105 --- Comment #8 from Christian David --- Git commit c836c3dec4509fb229cf2f71e31afe23512dac4e by Christian Dávid. Committed on 07/12/2013 at 17:02. Pushed by christiand into branch 'add-onlinebanking'. Started adding onlinebanking includi

[Kmymoney-devel] [kmymoney4] [Bug 328967] New: An exception in a slot called by a signal emitted in MyMoneyFile::commitTransaction() causes a crash with useless error message

2013-12-18 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=328967 Bug ID: 328967 Summary: An exception in a slot called by a signal emitted in MyMoneyFile::commitTransaction() causes a crash with useless error message Classification: Unclassified

[Kmymoney-devel] [kmymoney4] [Bug 249403] new payee fields: bank code number and account number

2013-12-27 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=249403 Christian David changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED CC

[Kmymoney-devel] Review Request 115377: Added kconf_update file for listErroneousTransactionColor conf-key

2014-01-29 Thread Christian David
uot; --key "listErronousTransactionColor" --type color "#00ff00" Moved kmymoney.upd to kconfig_update folder. And checked kmymoneyrc file and kconf_update logs => kmymoney.upd works Installed kmymoney in test environment. kmymoney.upd file was moved to correct folder => CMake

Re: [Kmymoney-devel] Review Request 115377: Added kconf_update file for listErroneousTransactionColor conf-key

2014-01-31 Thread Christian David
works Installed kmymoney in test environment. kmymoney.upd file was moved to correct folder => CMakeLists.txt works Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 327374] problems while getting bank details by HBCI

2014-02-06 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=327374 Christian David changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[Kmymoney-devel] [kmymoney4] [Bug 313237] No payee matching with aqbanking import (HBCI)

2014-02-06 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=313237 Christian David changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-02-10 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=330946 Christian David changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-02-10 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=330946 Christian David changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-02-10 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=330946 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

Re: [Kmymoney-devel] Review Request 115680: Performance optimization of the mymoney object container.

2014-02-11 Thread Christian David
tps://git.reviewboard.kde.org/r/115680/#comment34944> Only style: you can use qDeleteAll() for this ( http://qt-project.org/doc/qt-4.8/qtalgorithms.html#qDeleteAll-2 , map.clear() is still needed then) - Christian David On Feb. 11, 2014, 8:55 p.m., Cristian Oneț

[Kmymoney-devel] [kmymoney4] [Bug 313237] No payee matching with aqbanking import (HBCI)

2014-02-20 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=313237 Christian David changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[Kmymoney-devel] [kmymoney4] [Bug 331636] Net Worth Adding Assets and Liabilities

2014-03-08 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=331636 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #4 from

Re: [Kmymoney-devel] Review Request 110212: Add Merge Payee Option

2014-03-12 Thread Christian David
> On March 12, 2014, 2:33 p.m., Cristian Oneț wrote: > > It looks good to me too. Looks good to me as well. - Christian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110212/#review5274

[Kmymoney-devel] Review Request 116819: SQLCipher as database driver for encrypted SQLite databeses

2014-03-15 Thread Christian David
ATION kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116819/diff/ Testing --- Opened, changed, closed and reopend a (manualy created) encrypted database file. Performance to be tested... Thanks, Christian

Re: [Kmymoney-devel] Review Request 116819: SQLCipher as database driver for encrypted SQLite databeses

2014-03-15 Thread Christian David
ypted database file. Performance to be tested... Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 110212: Add Merge Payee Option

2014-03-19 Thread Christian David
> On March 19, 2014, 6:38 a.m., Cristian Oneț wrote: > > I was going to push this but before I did I gave it a try. I have the > > following remarks that can be seen in this video > > http://kmymoney2.sourceforge.net/screencasts/110212.ogv > > > > If I try to merge two payees why can't I selec

[Kmymoney-devel] Review Request 117630: Alkimia: Added a cmake package configuration file

2014-04-18 Thread Christian David
KMyMoney (=> it works) Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 116819: SQLCipher as database driver for encrypted SQLite databeses

2014-05-05 Thread Christian David
losed and reopend a (manualy created) encrypted database file. Performance to be tested... Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 334564] small deposits entered in foreign currency are wrongly converted to base currency

2014-05-11 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=334564 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #1 from

[Kmymoney-devel] [kmymoney4] [Bug 334564] small deposits entered in foreign currency are wrongly converted to base currency

2014-05-11 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=334564 --- Comment #4 from Christian David --- Then this may help to find the bug. As you said and as we can see, the calculations for 100 IDR and above are correct (100 IDR = 0,006212 € ≈ 0,01 €) . But below, somehow the exchange rate is reversed: 1 IDR

Re: [Kmymoney-devel] Review Request 117630: Alkimia: Added a cmake package configuration file

2014-05-12 Thread Christian David
CMAKE_PREFIX_PATH make clean in KMyMoney Compiled KMyMoney without setting ${GMP_LIBRARIES} anywhere in KMyMoney (=> it works) Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 118107: Calculate cleared balance in core

2014-05-13 Thread Christian David
> On May 13, 2014, 1:08 a.m., Marko Käning wrote: > > I'll incorporate it as soon as possible in a updated version of > > https://git.reviewboard.kde.org/r/112885/ . > > > > Thanks, Alvaro, for doing this job. > > > > I'll also report back as soon as I can regarding speed. > > Marko Käning wr

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-05-16 Thread Christian David
> On April 18, 2014, 1:34 p.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I'd suspected that I needed to make s

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-05-26 Thread Christian David
ease himself > about the appearance. Anyway, I start off with a display of ten rows, > which looks OK until the user back-tracks > and loads another file with different column widths. This can result in > the appearance/disappearance of the > horizontal scroll bar, whi

[Kmymoney-devel] [kmymoney4] [Bug 332436] Fees not saved in dividend transaction

2014-05-28 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=332436 Christian David changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-05-28 Thread Christian David
ease himself > about the appearance. Anyway, I start off with a display of ten rows, > which looks OK until the user back-tracks > and loads another file with different column widths. This can result in > the appearance/disappearance of the > horizontal scroll bar, whi

[Kmymoney-devel] [kmymoney4] [Bug 335129] Wrong account ordering at home page

2014-05-29 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=335129 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #6 from

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-06-19 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=330946 Christian David changed: What|Removed |Added Version Fixed In||4.6.5 -- You are receiving this mail

Re: [Kmymoney-devel] Review Request 119234: Transform KHolidays into an optional dependency.

2014-07-11 Thread Christian David
think this function is so important that it justifies having the pim libs a obligatory dependency. There will be many bug reports if a package maintainer forgets to compile with kdepimlibs. - Christian David On Juli 11, 2014, 9:58 nachm., Cristian Oneț wrote

Re: [Kmymoney-devel] Review Request 119234: Transform KHolidays into an optional dependency.

2014-07-12 Thread Christian David
> On Juli 11, 2014, 9:58 nachm., Christian David wrote: > > Is this only used until the pim libs are KF5 ready? Because I think this > > function is so important that it justifies having the pim libs a obligatory > > dependency. There will be many bug reports if a packa

[Kmymoney-devel] Review Request 119635: Replaced KMyMoneyGlobalSettings::setSubstringSearch(QWidget* w) to make kmm_config independent of widgets

2014-08-06 Thread Christian David
oved option again 5. restarted KMyMoney 6. tried completion for payees in register -- worked as expected -- Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 119639: Moved several widgets from the static into the shared library

2014-08-07 Thread Christian David
tor.h 6b3d65b1fa4632581fc9d2ddc7a26575aaba9a1a Diff: https://git.reviewboard.kde.org/r/119639/diff/ Testing --- KMyMoney still compiles and everything looks normal. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org

[Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-08-07 Thread Christian David
aved a .kmy file and into a database (to test the INSERT routine), inspected database by hand 3. Changed something and inspected database by hand afterward. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.k

Re: [Kmymoney-devel] Review Request 109913: transaction matching criteria change

2014-08-07 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109913/#review63994 --- Ship it! Ship It! - Christian David On April 8, 2013, 8

Re: [Kmymoney-devel] Review Request 109913: transaction matching criteria change

2014-08-07 Thread Christian David
> On Aug. 7, 2014, 5:51 nachm., Christian David wrote: > > Ship It! Sorry, wrong button. I think it should be discarded: using HBCI import the payee name is not a good criteria. It changes quite often in details (like "KDE e.V." -> "KDE E.V.", or "Co

Re: [Kmymoney-devel] Review Request 112026: Move XDG icons to icons/xdg, drop unused icon

2014-08-07 Thread Christian David
and merging it now could be a lot of work. Also it seems easier to me to solve that problem during/after the frameworks port. - Christian David On Aug. 14, 2013, 10:22 nachm., Yury Kudryashov wrote: > > --- > This is an auto

Re: [Kmymoney-devel] Review Request 119639: Moved several widgets from the static into the shared library

2014-08-08 Thread Christian David
dgets/kmymoneymvccombo.h a9d8e37ee0a600240c7ca4544964a448770d0a24 kmymoney/widgets/kmymoneyselector.h 6b3d65b1fa4632581fc9d2ddc7a26575aaba9a1a Diff: https://git.reviewboard.kde.org/r/119639/diff/ Testing --- KMyMoney still compiles and everything looks normal. Thanks, Christian

Re: [Kmymoney-devel] Review Request 119635: Replaced KMyMoneyGlobalSettings::setSubstringSearch(QWidget* w) to make kmm_config independent of widgets

2014-08-08 Thread Christian David
2. restarted KMyMoney 3. tried completion for payees in register -- worked as expected -- 4. removed option again 5. restarted KMyMoney 6. tried completion for payees in register -- worked as expected -- Thanks, Christian David ___ KMyMoney-devel maili

[Kmymoney-devel] [kmymoney4] [Bug 321649] No input form dialog appears when i try to add a new account in aqbanking

2014-08-10 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=321649 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #4 from

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-08-11 Thread Christian David
omatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119647/#review64213 ------- On Aug. 7, 2014, 4:57 nachm., Christian David wrote: > > --- > This is

[Kmymoney-devel] Review Request 119780: Corrected inconsistent usage of kvp key "iban" and "IBAN"

2014-08-14 Thread Christian David
://git.reviewboard.kde.org/r/119780/diff/ Testing --- Manipulated a file manually and reopened it. Keys were updated and removed correctly. Created a new account using the new account dialog and checked the file manually. Thanks, Christian David

Re: [Kmymoney-devel] Review Request 119780: Corrected inconsistent usage of kvp key "iban" and "IBAN"

2014-08-14 Thread Christian David
checked the file manually. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-08-15 Thread Christian David
an the long statement you created. This has the advantage of > > letting the DBMS cache the answer when any index changes. That probably has > > more of an effect before the change to index all the tables, but may be > > useful anyway. > > Christian David wrote: > I

[Kmymoney-devel] [kmymoney4] [Bug 338413] [onlinebanking] crash while entering account numbers and switching to different payee

2014-09-08 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=338413 Christian David changed: What|Removed |Added Assignee|kmymoney-devel@kde.org |christian-da...@web.de CC

[Kmymoney-devel] [kmymoney4] [Bug 338413] [onlinebanking] crash while entering account numbers and switching to different payee

2014-09-15 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=338413 Christian David changed: What|Removed |Added Latest Commit||http://commits.kde.org/kmym

Re: [Kmymoney-devel] Review Request 120339: New "Weboob" plugin for online banking

2014-09-23 Thread Christian David
it.reviewboard.kde.org/r/120339/#comment46989> NULL -> 0 kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46988> NULL -> 0 kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46993> Conside

[Kmymoney-devel] [kmymoney4] [Bug 331638] Transaction splitting ignores third decimal place

2014-09-24 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=331638 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

[Kmymoney-devel] [kmymoney4] [Bug 327663] crash on reports

2014-09-24 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=327663 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

[Kmymoney-devel] [kmymoney4] [Bug 296614] Ledger view scrolls to end on merging two transactions.

2014-09-24 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=296614 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

[Kmymoney-devel] [kmymoney4] [Bug 336258] Crash while editing a split

2014-09-24 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=336258 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

[Kmymoney-devel] [kmymoney4] [Bug 338684] Cleared amount is incorrect for liability accounts

2014-09-24 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=338684 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

[Kmymoney-devel] [kmymoney4] [Bug 338099] loan wizard doesn't show correct recipient

2014-09-24 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=338099 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

[Kmymoney-devel] Review Request 120377: Added emitting of signal in KMyMoneyAccountCombo::setSelected()

2014-09-26 Thread Christian David
oneyaccountcombo.cpp bde7d9b9935e82e714a74a41bfcfa426d045066a Diff: https://git.reviewboard.kde.org/r/120377/diff/ Testing --- In a short test I could not find any disadvantages. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney

Re: [Kmymoney-devel] Review Request 120377: Added emitting of signal in KMyMoneyAccountCombo::setSelected()

2014-10-03 Thread Christian David
on of some issues in the credit transfer editors. Diffs - kmymoney/widgets/kmymoneyaccountcombo.cpp bde7d9b9935e82e714a74a41bfcfa426d045066a Diff: https://git.reviewboard.kde.org/r/120377/diff/ Testing --- In a short test I could not find any disadvantages. Than

[Kmymoney-devel] [kmymoney4] [Bug 339103] reports cannot be created using the DB backend

2014-10-04 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=339103 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #9 from

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-10-04 Thread Christian David
ething and inspected database by hand afterward. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-10-05 Thread Christian David
( <= the new query ) 9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= what is stored in kmmFileInfo ) 2. Saved a .kmy file and into a database (to test the INSERT routine), inspected database by hand 3. Changed something and inspected database by hand afterward. Thanks, Christian

[Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-10-05 Thread Christian David
tps://git.reviewboard.kde.org/r/120499/diff/ Testing --- Opened an sqlite database which was created with KMyMoney 4.5.3, database version 6. The upgrade still worked and kmmFileInfo was still filled with correct data. Thanks, Christian David ___ KMyMoney-de

Re: [Kmymoney-devel] Review Request 120632: FAQ uses Capacity now

2014-10-17 Thread Christian David
General note, you do not have to do it: This should be replaced by or similar. faq.php <https://git.reviewboard.kde.org/r/120632/#comment47805> same as above - Christian David On Okt. 17, 2014, 7:11 nachm., Lars

Re: [Kmymoney-devel] Review Request 120632: FAQ uses Capacity now

2014-10-17 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120632/#review68620 --- Ship it! Ship It! - Christian David On Okt. 17, 2014, 7

Re: [Kmymoney-devel] Review Request 120632: FAQ uses Capacity now

2014-10-17 Thread Christian David
> On Okt. 17, 2014, 9:39 nachm., Jack Ostroff wrote: > > I apologize if I'm being dense, but what do you mean by "uses Capacity now" > > ? I see mainly a reordering of questions. > > Lars Meiendresch wrote: > Capacity is the framework for KDE Webpages (see > https://community.kde.org/KDE.

[Kmymoney-devel] [kmymoney4] [Bug 340244] Update the documentation screenshots

2014-10-22 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=340244 Christian David changed: What|Removed |Added CC||christian-da...@web.de --- Comment #1 from

Re: [Kmymoney-devel] Review Request 120818: Take advantage of the implicit sharing available in AlkValue.

2014-10-28 Thread Christian David
requirements. - Christian David On Okt. 26, 2014, 9:58 nachm., Cristian Oneț wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [Kmymoney-devel] Review Request 120818: Take advantage of the implicit sharing available in AlkValue.

2014-10-28 Thread Christian David
> On Okt. 28, 2014, 8:23 nachm., Christian David wrote: > > I think the minimum alkimia version must be adopted in the requirements. Just noticed: I am wrong - sorry. - Christian --- This is an automatically generated e-mail.

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-10-29 Thread Christian David
-------- On Okt. 5, 2014, 1:53 nachm., Christian David wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120499/ > -

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-02 Thread Christian David
onst mpq_class &valueRef() const``` is not ABI compatible. If it is not ABI compatible the so version must be increased. - Christian David On Okt. 26, 2014, 10:33 nachm., Cristian Oneț wrote: > > --- > This is an automatically

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-03 Thread Christian David
> On Nov. 2, 2014, 9:24 nachm., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-04 Thread Christian David
> On Nov. 2, 2014, 9:24 nachm., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the

[Kmymoney-devel] Review Request 121009: Added .reviewboard file

2014-11-06 Thread Christian David
Description --- So it is possible to use rb tools. Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121009/diff/ Testing --- This review request. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney

Re: [Kmymoney-devel] Review Request 121009: Added .reviewboard file

2014-11-06 Thread Christian David
, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 121030: Fixed a potential static initialization order fiasco in rr120815

2014-11-06 Thread Christian David
- libalkimia/alkvalue.h 7c02403adc641d1acf44c65fec39c1435e54405b libalkimia/alkvalue.cpp ae5d3a4ba61c4f0100d2598660ae76c432914d90 Diff: https://git.reviewboard.kde.org/r/121030/diff/ Testing --- KMyMoneys tests Thanks, Christian David ___ KMyMoney

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-06 Thread Christian David
> On Nov. 5, 2014, 7:51 nachm., Thomas Baumgart wrote: > > libalkimia/alkvalue.cpp, line 86 > > > > > > Does this get initialized under all circumstances? > > Cristian Oneț wrote: > It's a static so it's init

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue.

2014-11-07 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/#review70013 --- Ship it! - Christian David On Nov. 7, 2014, 8:06 nachm

Re: [Kmymoney-devel] Review Request 121030: Fixed a potential static initialization order fiasco in rr120815

2014-11-07 Thread Christian David
tests Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121192: Support Page, PlasmaMenu and Home Button

2014-11-20 Thread Christian David
ld not get removed. Seems to be an error during rebase. release-notes.rdf <https://git.reviewboard.kde.org/r/121192/#comment49455> Another merge error. release-notes.rdf <https://git.reviewboard.kde.org/r/121192/#comment49456> Another rebase error :( - Christian David

Re: [Kmymoney-devel] Review Request 121192: Support Page, PlasmaMenu and Home Button

2014-11-20 Thread Christian David
> On Nov. 20, 2014, 9:28 nachm., Marko Käning wrote: > > I wonder why 3 out of 4 diffs cannot be displayed here in ReviewBoard... > > Lars Meiendresch wrote: > There was an error with git. It should work now. But now you have another git issue now :( Git does not welcome new users. - Chri

Re: [Kmymoney-devel] Review Request 121192: Support Page, PlasmaMenu and Home Button

2014-11-22 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121192/#review70775 --- Ship it! Ship It! - Christian David On Nov. 22, 2014, 11

[Kmymoney-devel] [kmymoney4] [Bug 341304] New: upgrade database to version 1 does not work with sqlite

2014-11-26 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=341304 Bug ID: 341304 Summary: upgrade database to version 1 does not work with sqlite Product: kmymoney4 Version: git master Platform: Compiled Sources OS: All

[Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2014-11-29 Thread Christian David
FAIL! : MyMoneyDatabaseMgrTest::testBadConnections() 'sql->open(m_url, QIODevice::ReadWrite) != 0' returned FALSE. () Loc: [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(105)] Thanks, Christian David ___ KMyMoney-

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2014-11-29 Thread Christian David
ard.kde.org/r/121288/#comment49648> I think this can be replaced by return 0; upgradeDb() just removes all views and then it recreates them (if I did everything correctly). If someone knows that for sure please write me. - Christian David On Nov. 29, 201

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-11-29 Thread Christian David
ow_bug.cgi?id=339103#c9 are you saying this would > actually fix that bug? By looking at the upgradeToV7() I don't really > understand why the tags code is there in the first place. Since we didn't had > tags before there should be nothing to upgrade. > > Christian Da

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2014-12-02 Thread Christian David
sting (updated) --- make test only one fail left (see comments) XFAIL : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct behaviour in this case is clear. Loc: [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)] Thanks, Chri

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-12-03 Thread Christian David
ow_bug.cgi?id=339103#c9 are you saying this would > actually fix that bug? By looking at the upgradeToV7() I don't really > understand why the tags code is there in the first place. Since we didn't had > tags before there should be nothing to upgrade. > > Christian Da

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=296073 Christian David changed: What|Removed |Added Assignee|kmymoney-devel@kde.org |christian-da...@web.de CC

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=296073 Christian David changed: What|Removed |Added Latest Commit||http://commits.kde.org/kmym

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=296073 Christian David changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=296073 --- Comment #7 from Christian David --- > Could you please remove (new) part from its name ? and also its sort name ? > Because Our currency changed its name from New Turkish Lira to Turkish Lira > again. Already did this (http://commit

[Kmymoney-devel] [kmymoney4] [Bug 338296] In Ledger: Keyboard shortcut for Search (Alt-E) does not work

2015-01-03 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=338296 Christian David changed: What|Removed |Added CC||christian-da...@web.de

[Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-03 Thread Christian David
Works fine. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338296] In Ledger: Keyboard shortcut for Search (Alt-E) does not work

2015-01-03 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=338296 --- Comment #1 from Christian David --- Added patch: https://git.reviewboard.kde.org/r/121803/ -- You are receiving this mail because: You are on the CC list for the bug. ___ KMyMoney-devel mailing list

Re: [Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-03 Thread Christian David
ey/widgets/registersearchline.cpp cae7a3fa22bf5ccd559ebeefc12885bff8d1051d Diff: https://git.reviewboard.kde.org/r/121803/diff/ Testing --- Opened with english local and tested shortcut. Works fine. Thanks, Christian David ___ KMyMoney-devel mailing lis

Re: [Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-04 Thread Christian David
E-CREATION kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION kmymoney/widgets/registersearchline.cpp cae7a3fa22bf5ccd559ebeefc12885bff8d1051d Diff: https://git.reviewboard.kde.org/r/121803/diff/ Testing --- Opened with english local and tested shortcut. Works fi

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2015-01-04 Thread Christian David
ata. Thanks, Christian David ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2015-01-04 Thread Christian David
sting --- make test only one fail left (see comments) XFAIL : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct behaviour in this case is clear. Loc: [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)] Thanks, Christian

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2015-01-04 Thread Christian David
> On Nov. 29, 2014, 10:33 vorm., Christian David wrote: > > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 740 > > <https://git.reviewboard.kde.org/r/121288/diff/1/?file=331058#file331058line740> > > > > This is still an open issue: ```m_storage->fi

[Kmymoney-devel] [kmymoney4] [Bug 339103] reports cannot be created using the DB backend

2015-01-04 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=339103 --- Comment #10 from Christian David --- I published a Google Code In task to start solving this issue. So please do not fix it within the next 15 days ;) About Google Code In: http://www.google-melange.com/gci/homepage/google/gci2014 -- You are

Re: [Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-04 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121803/#review73079 ------- On Jan. 4, 2015, 5:20 nachm., Christian David wrote: >

  1   2   3   4   >