----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121288/ -----------------------------------------------------------
Review request for KMymoney. Repository: kmymoney Description ------- So the upgrade routine is not executed starting from version 0 - which is useless as the database should be the most recent version anyway. Also removed the version param from createTables(int version). It was not used and was totaly useless as createTables() calls upgradeDb(). This is also a workaround bug 341304 as the upgradeToV1() won't be called after creation of tables anymore. The bug persists if the user has a version 0 database. CCBUG: 341304 Diffs ----- kmymoney/mymoney/storage/mymoneystoragesql.cpp 2f403b1151cf86d5092981e60a5b7e0b308736b6 kmymoney/mymoney/storage/mymoneystoragesql.h ae79b484186e700367f9a4362ffd19772825cf22 kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 80ff5a725e41e2a344cf32019b22803059ab9f93 Diff: https://git.reviewboard.kde.org/r/121288/diff/ Testing ------- make test only one fail left (see comments) FAIL! : MyMoneyDatabaseMgrTest::testBadConnections() 'sql->open(m_url, QIODevice::ReadWrite) != 0' returned FALSE. () Loc: [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(105)] Thanks, Christian David
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
