----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120339/#review67307 -----------------------------------------------------------
Hi, that looks really, really cool! I wanted to review it but could just briefly look over it leaving a lot of minor notes. Maybe someone else can do a more deeply review. CMakeLists.txt <https://git.reviewboard.kde.org/r/120339/#comment46983> This comment does not fit. kmymoney/plugins/weboob/CMakeLists.txt <https://git.reviewboard.kde.org/r/120339/#comment46992> If these lines are not needed, you should remove them. kmymoney/plugins/weboob/dialogs/webaccount.cpp <https://git.reviewboard.kde.org/r/120339/#comment46991> This file does not follow the coding style kmymoney/plugins/weboob/plugin.hpp <https://git.reviewboard.kde.org/r/120339/#comment46990> In KMyMoney c++ headers usually have the .h suffix (some of your files use .h as well). Consider using .h everywhere. kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46984> Do not use "NULL" but 0 (the C++ way of doing this). kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46985> Maybe you want to remove this debug message. There is no reason for it at this stage of your work. kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46986> You should remove this debug message. kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46987> Just an idea: name the keys weboob-...? kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46989> NULL -> 0 kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46988> NULL -> 0 kmymoney/plugins/weboob/plugin.cpp <https://git.reviewboard.kde.org/r/120339/#comment46993> Consider removing this debug message. - Christian David On Sept. 23, 2014, 4:46 nachm., Florent Fourcot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120339/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 4:46 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Weboob (http://weboob.org) is a library and a collection of applications to > extract data from the Web. One of the features is to simplify online banking, > on many french banks and several outside of France. About 33 modules are > currently available. > > This module provides a easy way to import the transactions extracted by > Weboob in Kmymoney, providing an online banking like the aqbanking module. > > > Diffs > ----- > > kmymoney/plugins/weboob/dialogs/webaccount.ui PRE-CREATION > kmymoney/plugins/weboob/kmm_weboob.desktop PRE-CREATION > CMakeLists.txt d8f9ef4 > kmymoney/plugins/CMakeLists.txt eb3a62f > kmymoney/plugins/weboob/CMakeLists.txt PRE-CREATION > kmymoney/plugins/weboob/dialogs/CMakeLists.txt PRE-CREATION > kmymoney/plugins/weboob/dialogs/mapaccount.hpp PRE-CREATION > kmymoney/plugins/weboob/dialogs/mapaccount.cpp PRE-CREATION > kmymoney/plugins/weboob/dialogs/mapaccount.ui PRE-CREATION > kmymoney/plugins/weboob/dialogs/webaccount.h PRE-CREATION > kmymoney/plugins/weboob/dialogs/webaccount.cpp PRE-CREATION > kmymoney/plugins/weboob/weboob.cpp PRE-CREATION > kmymoney/plugins/weboob/weboob.py PRE-CREATION > kmymoney/plugins/weboob/kmm_weboob.rc PRE-CREATION > kmymoney/plugins/weboob/plugin.hpp PRE-CREATION > kmymoney/plugins/weboob/plugin.cpp PRE-CREATION > kmymoney/plugins/weboob/weboob.hpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120339/diff/ > > > Testing > ------- > > The module needs krosspython to work. The tests have been ran on a Debian > Stable, with a krosspython in version 4.8. > It looks like a bug in krosspython > (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762593) prevents to use it > with a newer krosspython version. > > > Thanks, > > Florent Fourcot > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
