----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120377/ -----------------------------------------------------------
Review request for KMymoney. Repository: kmymoney Description ------- The accountSelected(QString) signal is emitted if KMyMoneyAccountCombo::setSelected() is used to change the selection. This should be the behavior expected by any user of this signal. The name "accountSelected" could be meant as "account selected by user". Could someone with a better understanding of the internals tell me if my change does not cause any issues. Also: are there other ways to change selection which do not emit this signal? Btw:?This is the most elegant solution of some issues in the credit transfer editors. Diffs ----- kmymoney/widgets/kmymoneyaccountcombo.cpp bde7d9b9935e82e714a74a41bfcfa426d045066a Diff: https://git.reviewboard.kde.org/r/120377/diff/ Testing ------- In a short test I could not find any disadvantages. Thanks, Christian David
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
