----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120818/#review69331 -----------------------------------------------------------
I think the minimum alkimia version must be adopted in the requirements. - Christian David On Okt. 26, 2014, 9:58 nachm., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120818/ > ----------------------------------------------------------- > > (Updated Okt. 26, 2014, 9:58 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Since the values 1 and -1 seem to be used pretty often (in loops) it's worth > to have static values for these constants to benefit from implicit sharing in > the places where these values are necessary. > > The sharing of value 0 is already provided by AlkValue so we don't need a > static value for 0. > > This patch will work just fine with alkimia 4.3.2 but the advantages will be > visible when combined with REVIEW 120815. > > > Diffs > ----- > > kmymoney/reports/pivotgrid.cpp b608a28257ba60c4ec83eb744e1891f58c6dac58 > kmymoney/reports/pivotgridtest.cpp e0deaf07b2fadcbc54dabe96633adde653bbda4f > kmymoney/reports/pivottable.cpp 340f7a8d6ec98bcc2968bec12ecb9706b6cbfff0 > kmymoney/reports/querytable.cpp cd4371946974c8936c076dd4865c763ce6f77edb > kmymoney/reports/reportaccount.cpp d3b42c33ef09b31545639092676dc76c5d737b65 > kmymoney/views/kforecastview.cpp e5120b03aa345929d92d7af508f16ee54a7e8309 > kmymoney/views/kgloballedgerview.cpp > 22f40e139fc1d5d9280c84539bdcf9ad457f7de1 > kmymoney/views/khomeview.cpp 5f3c66608564edcc6a078dbda9d78122b166c646 > kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp > 56e7d4112fc4b6b95b11d9de58b47689e5e2e643 > kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp > 801b76147b35af7548357ef200a84a8714947374 > kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp > 847ff8c89055774513231c3bb65d1d4155b8407b > kmymoney/wizards/newloanwizard/knewloanwizard.cpp > 99ea10fc2ace66f1590d53a7555b39818fc054b3 > kmymoney/dialogs/investactivities.cpp > ca425f99d70169d7ba6c80870ab6be86e8069970 > kmymoney/dialogs/investtransactioneditor.cpp > 4f870039d2de55d73550c944c7f5e3403eb9abd0 > kmymoney/dialogs/kcurrencycalculator.cpp > b50aa8a1c6db0fd569adc97cf01877c76465d52f > kmymoney/dialogs/kmymoneypricedlg.cpp > 9aa220fb4a558ef0945bb68be85c39b927451e8c > kmymoney/dialogs/knewaccountdlg.cpp > 47c20a2708cd998b4b53ee2d97d5dcc1e6bd6021 > kmymoney/kmymoney.cpp 84bd9a3a6da487ba0d41bcca48dc82b4842f1c28 > kmymoney/models/accountsmodel.cpp 37384d26e7bd7321ddf247b35517da28d4e11a45 > kmymoney/mymoney/mymoneyaccounttest.cpp > 2506f8eb4efb0053e3e1c7c7ce755b27d288345d > kmymoney/mymoney/mymoneyfile.cpp dd4af2e3a9883998f2ad95ccecb5bcbfa23068db > kmymoney/mymoney/mymoneyfiletest.cpp > 1e196ad92f3890e2e6ecfbcc9da66dad91e6dcf7 > kmymoney/mymoney/mymoneyforecast.cpp > 9f3e384584f4ded4f72be830fa2dd1f0b18017fd > kmymoney/mymoney/mymoneyforecasttest.cpp > dc098af51620d858728ed706e189d9218ef49543 > kmymoney/mymoney/mymoneymoney.h 033983b4fe4c2c140cbeb7b55cdaf9d18c4db154 > kmymoney/mymoney/mymoneymoney.cpp 5de7fa9085552c7fae01b7380258ea3752672c52 > kmymoney/mymoney/mymoneyprice.cpp 27b847480b3800d512d81dba66639f224c220dfd > kmymoney/mymoney/mymoneypricetest.cpp > 1acd388a8928a8d9fcd3e04afd694836c7bb7b2e > kmymoney/mymoney/mymoneysplit.cpp 2f811328a10e4e612d4431c81b467f9e69a57c3b > kmymoney/mymoney/mymoneytransactionfilter.cpp > 1883971dcf5fb1ea771efb178b58a30a1698ad65 > kmymoney/mymoney/storage/mymoneystorageanon.cpp > 08f42f2b8c6cd89fcbb9b449a46bc8406e30746b > kmymoney/reports/objectinfotable.cpp > 49d3ae1ed98f374f82c5ed6832a00c12b48a132a > kmymoney/reports/pivotgrid.h 8205eb22ca40e01b66310e33b035aac70b63b675 > > Diff: https://git.reviewboard.kde.org/r/120818/diff/ > > > Testing > ------- > > Ran KMyMoney and the tests. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
