Re: Review Request 129790: Add Capital Gains report

able to handle the different requirements of different countries? - Allan Anderson On Jan. 7, 2017, 7:50 p.m., Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 128874: Free QFileDialog memory

out avoids the abort. - Allan Anderson On Sept. 16, 2016, 4:38 p.m., Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

> On Sept. 11, 2016, 10:09 a.m., Allan Anderson wrote: > > It was actually on my todo list to remove the QIF facility as it no longer > > had any purpose. It was a relict from early days before CSV import became > > fully established. > > I had indicated this

Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

> On Sept. 11, 2016, 10:09 a.m., Allan Anderson wrote: > > It was actually on my todo list to remove the QIF facility as it no longer > > had any purpose. It was a relict from early days before CSV import became > > fully established. > > I had indicated this

Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

ature had been removed. I would still have gone ahead, but the change would have had to be reverted in that circumstance. Perhaps you see a need? - Allan Anderson On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote: > > --- &

Re: Review Request 128511: Move displayLine to CSVWizard

> On July 24, 2016, 10:54 a.m., Thomas Baumgart wrote: > > Again, just visual inspection. Looks good to me besides the two little > > nitpicks. Someone with more knowledge about the functionality should check > > as well. If that includes me, then I agree. - Allan -

Re: Review Request 128061: Fix precision of split value

> On June 2, 2016, 1 p.m., Allan Anderson wrote: > > This is not a good area for me, and takes me out of my comfort zone. > > However, I've been having a look at this, and there are one or two points, > > which may or may not be relevant. > > Firstly, the file

Re: Review Request 128061: Fix precision of split value

vertDenominator(fraction).canonicalize());" For the first split, I get "16180.52", but with the canonicalize() removed, I get "16180.525000". The second split gives "-16180.525000". Whether or not this is relevant, I really don't know and an expert opinion is

Re: Review Request 128061: Fix precision of split value

ing problem caught in https://bugs.kde.org/show_bug.cgi?id=303026 could still happen. Can you please comment on reviewboard so that we can think of how to deal with the situation? It would be nice if you can provide me with a testcase (probably just different values) that fails. - Allan Anderson

Re: Review Request 127712: Bug 360747 CSV Importer detects more columns than are assigned

> On April 27, 2016, 7:11 p.m., Cristian Oneț wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 858 > > > > > > Is this local variable really necessary? I had noticed this. Whilst it is used, I s

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

= profilesGroup.readEntry("ShrsinParam", > > m_shrsinList);``` > > > > The if() is very long and not needed here. However, I still do not know > > if this is the issue. Also the ```i18nc()s``` from ```init()``` could go > > here if the readSetting

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

= profilesGroup.readEntry("ShrsinParam", > > m_shrsinList);``` > > > > The if() is very long and not needed here. However, I still do not know > > if this is the issue. Also the ```i18nc()s``` from ```init()``` could go > > here if the readSetting

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

> On April 3, 2016, 12:37 p.m., Allan Anderson wrote: > > > > Allan Anderson wrote: > We have had discussons about this in the bug report. I think you are > confusing the issue by stating your experience (using the Polish translation) > as a general issue.

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

> On April 3, 2016, 12:37 p.m., Allan Anderson wrote: > > We have had discussons about this in the bug report. I think you are confusing the issue by stating your experience (using the Polish translation) as a general issue. For me, if I delete the csvimporterrc file and then

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/#review94211 --- - Allan Anderson On April 3, 2016, 4:45 a.m., Łukasz

Re: Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

tivities.h d2e2a76 kmymoney/dialogs/investactivities.cpp 29c7957 kmymoney/dialogs/investtransactioneditor.cpp 882e5a0 Diff: https://git.reviewboard.kde.org/r/124815/diff/ Testing --- Create and edit numerous relevant transactions. Thanks, Allan Anderson

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

, > "KMyMoney has found a scheduled > transaction which matches an imported transaction." > "Schedule name: %2" > "Transaction: %3 %4" >

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

, > "KMyMoney has found a scheduled > transaction which matches an imported transaction." > "Schedule name: %2" > "Transaction: %3 %4" >

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

, > "KMyMoney has found a scheduled > transaction which matches an imported transaction." > "Schedule name: %2" > "Transaction: %3 %4" >

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

, > "KMyMoney has found a scheduled > transaction which matches an imported transaction." > "Schedule name: %2" > "Transaction: %3 %4" >

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

> On Jan. 24, 2016, 9:02 p.m., Christian David wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1458 > > > > > > Translated strings should not be combined, as it confuses the > > translators. It i

Re: Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

ies.cpp 29c7957 kmymoney/dialogs/investtransactioneditor.cpp 882e5a0 Diff: https://git.reviewboard.kde.org/r/124815/diff/ Testing --- Create and edit numerous relevant transactions. Thanks, Allan Anderson

Re: [Kmymoney-devel] Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

rd.kde.org/media/uploaded/files/2015/09/14/068c1b15-090b-45a8-be9a-83bdc69de995__0001-BUG-347166.patch Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 124115: BUG:349027 Fix transaction classed as a "transfer" instead of a "withdrawal".

three are > > accessible. How can I reproduce the problem? Can you attach necessary files > > to the bug entry? > > > > In case it's a KMyMoney general problem and not related to any import > > action, one should be capable of entering a transaction via the fo

Re: [Kmymoney-devel] Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

kmymoney/dialogs/investtransactioneditor.cpp 882e5a0 Diff: https://git.reviewboard.kde.org/r/124815/diff/ Testing --- Create and edit numerous relevant transactions. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde

Re: [Kmymoney-devel] Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124815/#review84041 --- On Aug. 19, 2015, 10:14 a.m., Allan Anderson wrote: > > --- > This is

Re: [Kmymoney-devel] Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

activities.h d2e2a76 kmymoney/dialogs/investactivities.cpp 29c7957 kmymoney/dialogs/investtransactioneditor.cpp 882e5a0 Diff: https://git.reviewboard.kde.org/r/124815/diff/ Testing --- Create and edit numerous relevant transactions. Tha

[Kmymoney-devel] Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

24815/diff/ Testing --- Create and edit numerous relevant transactions. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 124115: BUG:349027 Fix transaction classed as a "transfer" instead of a "withdrawal".

three are > > accessible. How can I reproduce the problem? Can you attach necessary files > > to the bug entry? > > > > In case it's a KMyMoney general problem and not related to any import > > action, one should be capable of entering a transaction via the fo

Re: [Kmymoney-devel] Review Request 124115: BUG:349027 Fix transaction classed as a "transfer" instead of a "withdrawal".

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124115/#review81525 --- On June 17, 2015, 1:11 p.m., Allan Anderson wrote: > >

[Kmymoney-devel] Review Request 124115: BUG:349027 Fix transaction classed as a "transfer" instead of a "withdrawal".

, but in KMyMoney itself. Diffs - kmymoney/widgets/transaction.cpp 77bbcb1 Diff: https://git.reviewboard.kde.org/r/124115/diff/ Testing --- Checked with downloads and also manually edited transactions. Thanks, Allan Anderson ___ KM

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

marked as submitted. Review request for KMymoney. Changes --- Submitted with commit 0dc7e903d389c458289a92634f9e346928316173 by Allan Anderson to branch master. Bugs: 340656 http://bugs.kde.org/show_bug.cgi?id=340656 Repository: kmymoney Description --- Fix display on high

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

spite of its size, there is not a huge amount of change involved. - Allan Anderson On Feb. 3, 2015, 12:27 a.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

> On Feb. 12, 2015, 9:24 p.m., Christian David wrote: > > File Attachment: Updated patch - 0002-BUG-340656.patch > > <https://git.reviewboard.kde.org/r/122364/#fcomment365> > > > > ```Qt::WindowFlags eFlags = windowFlags();``` (space removed) > > Alla

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

> On Feb. 12, 2015, 9:24 p.m., Christian David wrote: > > File Attachment: Updated patch - 0002-BUG-340656.patch > > <https://git.reviewboard.kde.org/r/122364/#fcomment357> > > > > This should be done in a more modular fashion (general annotation). > >

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

done that, without knowing it was a requirement/style issue. What about the header #include in a cpp file? > On Feb. 12, 2015, 9:24 p.m., Christian David wrote: > > File Attachment: Updated patch - 0002-BUG-340656.patch > > <https://git.reviewboard.kde.org/r/122364

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

oid making this patch even larger. I'm unable to test on Windows. File Attachments (updated) Updated patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/6e4dad98-936c-4ca0-8804-c4abb9b51438__0002-BUG-340656.patch Tha

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

tps://git.reviewboard.kde.org/r/122364/#review75159 ------- On Feb. 1, 2015, 2:04 p.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail.

[Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

not yet included. I've completed its testing, but as it's a little-used window, I've held it back to avoid making this patch even larger. I'm unable to test on Windows. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KM

Re: [Kmymoney-devel] Review Request 120153: Remove the OFX investment transactions amount sign inversion hack.

#x27;ve removed the -ve sign and it does partially correct this problem, but I need to look deeper because I suspect there is an earlier bug too. - Allan Anderson On Sept. 21, 2014, 9:33 a.m., Cristian Oneț wrote: > > --- > This is

Re: [Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows.

ialog' keeps getting new members and judging by > > their names it has become the most complex state machine I've ever seen. > > > > Here are some nitpicks I came up with by looking at the request. > > Allan Anderson wrote: > Thanks Cristian. As you say,

Re: [Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows.

://git.reviewboard.kde.org/r/120507/diff/ Testing --- Tested with numerous banking and investment files from different sources, on Linux Mint KDE and Ubuntu Unity. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https

Re: [Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows.

t; > line) are pretty well highlighted by reviewboard. Oops, missed that extra line when lookin through the patch. Did you say you were going to look into using a more up-to-date version of astyle? - Allan ------- This is an

[Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows. Also

investment files from different sources, on Linux Mint KDE and Ubuntu Unity. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.

h on Linux Mint and Ubuntu, with a large number of different files. I am not able to test on Windows, having only XP. I don't know if these changes help with the radio button issue on Windows, as I am not able to reproduce the problem here, the radio, and all other, buttons work as expect

Re: [Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.

the behaviour of the radio buttons? - Allan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120260/#review66860 --- On Sep

[Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.

ws, having only XP. I don't know if these changes help with the radio button issue on Windows, as I am not able to reproduce the problem here, the radio, and all other, buttons work as expected. Thanks, Allan Anderson ___ KMyMoney-devel mailing

Re: [Kmymoney-devel] Review Request 120153: Remove the OFX investment transactions amount sign inversion hack.

m the logfile) is imported into a checking account, the sign now is correct. I've also imported a number of my own non-OFX files and they too are OK. I'm not an OFX user, and I'm assuming that the second half of the file is informational and not for import. - Allan Anderson On Sept

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I&#

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

ree, I can describe any proposed changes. I don't want to stray away from your major changes, though, obviously. - Allan Anderson On April 17, 2014, 9:23 p.m., Cristian Oneț wrote: > > --- > This is an automat

Re: [Kmymoney-devel] Review Request 115338: Fix loosing track of check number if check number sequence is interrupted.

kmymoney/dialogs/transactioneditor.cpp 3c148d8 kmymoney/dialogs/transactioneditor.h db86832 Diff: https://git.reviewboard.kde.org/r/115338/diff/ Testing --- Numerous manual test cases run. Unit tests run. Thanks, Allan Anderson ___ KMyMone

Re: [Kmymoney-devel] Review Request 115302: Fix loosing track of check number if check number sequence is interrupted.

can now be used, and produce correct 'next numbers'. Diffs - kmymoney/kmymoneyutils.cpp e89528e kmymoney/kmymoneyutils.h a899121 kmymoney/kmymoney.cpp 7a2fd4f kmymoney/dialogs/transactioneditor.cpp 3c148d8 kmymoney/dialogs/transactioneditor.h db86832 Diff: https://git.revi

[Kmymoney-devel] Review Request 115338: Fix loosing track of check number if check number sequence is interrupted.

b86832 Diff: https://git.reviewboard.kde.org/r/115338/diff/ Testing --- Numerous manual test cases run. Unit tests run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 115302: Fix loosing track of check number if check number sequence is interrupted.

kmymoney/kmymoneyutils.h a899121 kmymoney/kmymoney.cpp 7a2fd4f kmymoney/dialogs/transactioneditor.cpp 3c148d8 kmymoney/dialogs/transactioneditor.h db86832 Diff: https://git.reviewboard.kde.org/r/115302/diff/ Testing --- Numerous manual test cases run. Unit tests run. Thanks, Allan Anderson _

Re: [Kmymoney-devel] Review Request 115302: Fix loosing track of check number if check number sequence is interrupted.

numeric can now be used, and produce correct 'next numbers'. Diffs - kmymoney/kmymoneyutils.cpp 7058557 kmymoney/kmymoneyutils.h f64a55e kmymoney/dialogs/transactioneditor.cpp 26e7672 kmymoney/dialogs/transactioneditor.h 25705a0 Diff: https://git.reviewboard.k

[Kmymoney-devel] Review Request 115302: Fix loosing track of check number if check number sequence is interrupted.

ney/kmymoneyutils.cpp 7058557 kmymoney/kmymoneyutils.h f64a55e kmymoney/dialogs/transactioneditor.cpp 26e7672 kmymoney/dialogs/transactioneditor.h 25705a0 Diff: https://git.reviewboard.kde.org/r/115302/diff/ Testing --- Numerous manual test cases run. Unit tests run. Thanks, Allan

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

tachments Part 2 https://git.reviewboard.kde.org/media/uploaded/files/2013/10/20/7aac2cee-e36f-466f-995f-d80c526094c3__0001-BUG-319801_REVIEW113143_-_Fix_losing_track_of_check_numberB.patch Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

a mess now, so I'll withdraw it and re-submit the cleaned up version. - Allan Anderson On Oct. 20, 2013, 7:15 p.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Kmymoney-devel] Review Request 114352: Bug 312816 - Fine tune the resizing of the register and the transaction form.

uch resizing of many checking and investment accounts, both while in edit mode and not. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

> On Jan. 4, 2014, 12:23 a.m., Allan Anderson wrote: > > An edit disappeared so... Git commit 3422b775db80fd1956775eb94370c9e950f2b52e by Allan Anderson. Committed on 24/10/2013 at 22:34. Pushed by allananderson into branch 'master'. Reinstate previous fix, allow memo fie

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113427/#review46743 --- - Allan Anderson On Oct. 24, 2013, 11:06 p.m., Allan

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

> On Jan. 2, 2014, 12:19 a.m., Allan Anderson wrote: > > I've noticed a potential problem. When making a multi-edit, the memo field > > appears cleared. If any other edit is made, and the edit is entered, the > > original memos are cleared too, which is undesirable.

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

> On Jan. 2, 2014, 12:19 a.m., Allan Anderson wrote: > > I've noticed a potential problem. When making a multi-edit, the memo field > > appears cleared. If any other edit is made, and the edit is entered, the > > original memos are cleared too, which is undesirable.

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113427/#review46543 --- On Oct. 24, 2013, 11:06 p.m., Allan Anderson wrote: > >

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

wanting to have an empty field." I hope this is acceptable. It also avoids the requirement for a user who wants an empty memo, to have to enter a character into the empty memo field in order to delete it to trigger a connect. - Allan Anderson On Oct. 24, 2013, 11:06 p.m.,

Re: [Kmymoney-devel] Review Request 114352: Bug 312816 - Fine tune the resizing of the register and the transaction form.

this. - Allan Anderson On Dec. 8, 2013, 6:19 p.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

[Kmymoney-devel] Review Request 114352: Bug 312816 - Fine tune the resizing of the register and the transaction form.

that of the widest sub-string. Diffs - kmymoney/views/kgloballedgerview.cpp 000393c kmymoney/widgets/register.cpp 56bf46d Diff: http://git.reviewboard.kde.org/r/114352/diff/ Testing --- Much resizing of many checking and investment accounts, both while in edit mode and n

[Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

/transactioneditor.cpp 71d94ec Diff: http://git.reviewboard.kde.org/r/113427/diff/ Testing --- Numerous groups of investment and checking transactions entered and edited correctly. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

> On Oct. 20, 2013, 7:27 p.m., Allan Anderson wrote: > > File Attachment: Part 2 - 0001-BUG-319801 REVIEW:113143 - Fix losing track > > of check numberB.patch > > <http://git.reviewboard.kde.org/r/113143/#fcomment123> > > > > This is the second pa

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

t;http://git.reviewboard.kde.org//r/113143/#fcomment122> This is the second patch, for which I did an 'add file', and which possibly I should not have done. - Allan Anderson On Oct. 20, 2013, 7:15 p.m., Allan Anderson wrote: > >

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

cked, including coping with all values in the unit tests. The unit test runs OK. File Attachments (updated) Part 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/10/20/7aac2cee-e36f-466f-995f-d80c526094c3__0001-BUG-319801_REVIEW113143_-_Fix_losing_track_of_check_n

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

kde.org/r/113143/diff/ Testing --- Many manual entries checked, including coping with all values in the unit tests. The unit test runs OK. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

patch. Apologies. - Allan Anderson On Oct. 19, 2013, 4:53 p.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp cfb0f71 kmymoney/widgets/transactioneditorcontainer.h f77b195 Diff: http://git.reviewboard.kde.org/r/113143/diff/ Testing --- Many manual entries checked, including coping with all values in the unit tests

Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

> On Oct. 11, 2013, 11:53 a.m., Allan Anderson wrote: > > Can you hold for a little while, please. I think I've found a problem. > > Allan Anderson wrote: > I think the problem with the column widths is to do with the extra space > that is needed when a transac

Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

> On Oct. 11, 2013, 11:53 a.m., Allan Anderson wrote: > > Can you hold for a little while, please. I think I've found a problem. > > Allan Anderson wrote: > I think the problem with the column widths is to do with the extra space > that is needed when a transac

Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

> On Oct. 11, 2013, 11:53 a.m., Allan Anderson wrote: > > Can you hold for a little while, please. I think I've found a problem. I think the problem with the column widths is to do with the extra space that is needed when a transaction is opened for editing. That extra

Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

und a problem. - Allan Anderson On Sept. 29, 2013, 11:37 a.m., Cristian Oneț wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.

columns. I'm still thinking about users with small screens and the excess width of several other columns. Any objections to me looking into this? Also, I think I'd found a couple of bunches of code that served no apparent purpose (duplication). - Allan Anderson On Sept. 29, 2013,

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

airly unimportant area, without becoming more involved. Diffs (updated) - kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 71d94ec Diff: http://git.reviewboard.kde.org/r/113143/diff/ Testing --- Many manual

Re: [Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

t'? > Please pass a 'const QString &' as a parameter instead of by-value. - Done. I did originally have 'numericPart' as public, but had an impression that member variables were best not public so changed it. Lack of formal tuition rears its head again.

[Kmymoney-devel] Review Request 113143: Fix loosing track of check number if check number sequence is interrupted.

fb kmymoney/mymoney/mymoneyfile.cpp ff7302c Diff: http://git.reviewboard.kde.org/r/113143/diff/ Testing --- Many manual entries checked, including coping with all values in the unit tests. The unit test runs OK. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

http://git.reviewboard.kde.org/r/112947/diff/ Testing --- Entering and editing various transaction types to ensure only the appropriate widgets became visible or hidden when required. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

alogs/transactioneditor.cpp cfb0f71 kmymoney/widgets/transactioneditorcontainer.h f77b195 Diff: http://git.reviewboard.kde.org/r/112947/diff/ Testing --- Entering and editing various transaction types to ensure only the appropriate widgets became visible or hidden when required. Thanks, Allan And

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

On Oct. 2, 2013, 4:31 a.m., Allan Anderson wrote: > > It seems that there was a problem in the way you created the new patch. You > > mixed in some other patches and undid some recents commits with it so it > > can't be shipped unless you fix that. > > Cristian On

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

ail. To reply, visit: http://git.reviewboard.kde.org/r/112947/#review41094 --- On Oct. 1, 2013, 7:33 p.m., Allan Anderson wrote: > > --- > This is an automat

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

) is > > called above? This only keeps the data in the widget. > > Allan Anderson wrote: > Yes it is. As explained above, the data in the widget is the name of the > interest category, but we're dealing now with a new fee category. If we > clear this text, the inte

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

nsure only the appropriate widgets became visible or hidden when required. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

) is > > called above? This only keeps the data in the widget. > > Allan Anderson wrote: > Yes it is. As explained above, the data in the widget is the name of the > interest category, but we're dealing now with a new fee category. If we > clear this text, the inte

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

) is > > called above? This only keeps the data in the widget. > > Allan Anderson wrote: > Yes it is. As explained above, the data in the widget is the name of the > interest category, but we're dealing now with a new fee category. If we > clear this text, the inte

Re: [Kmymoney-devel] Review Request 112971: Improve the column sizes auto adjustment of the register

that when the window is shrinking, the Details column can go all together before the other columns start to shrink. However, that issue should go if/when my column resizing fix goes ahead. I think it would be cheeky of me to say 'Ship it'! - Allan Anderson On Sept. 28, 2013, 8:50 a.m.

Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.

) is > > called above? This only keeps the data in the widget. > > Allan Anderson wrote: > Yes it is. As explained above, the data in the widget is the name of the > interest category, but we're dealing now with a new fee category. If we > clear this text, the inte

  1   2   3   >