> On Jan. 4, 2014, 12:23 a.m., Allan Anderson wrote: > >
An edit disappeared so... Git commit 3422b775db80fd1956775eb94370c9e950f2b52e by Allan Anderson. Committed on 24/10/2013 at 22:34. Pushed by allananderson into branch 'master'. Reinstate previous fix, allow memo field to be empty, and allow date to be edited. M +1 -1 kmymoney/dialogs/investactivities.cpp M +2 -0 kmymoney/dialogs/investactivities.h M +19 -5 kmymoney/dialogs/investtransactioneditor.cpp M +3 -2 kmymoney/dialogs/investtransactioneditor.h M +28 -5 kmymoney/dialogs/transactioneditor.cpp M +4 -0 kmymoney/dialogs/transactioneditor.h http://commits.kde.org/kmymoney/3422b775db80fd1956775eb94370c9e950f2b52e - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113427/#review46743 ----------------------------------------------------------- On Oct. 24, 2013, 11:06 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113427/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 11:06 p.m.) > > > Review request for KMymoney. > > > Bugs: 289351 > http://bugs.kde.org/show_bug.cgi?id=289351 > > > Repository: kmymoney > > > Description > ------- > > There was a previous fix for this problem - Git commit > 9485826cfb50816d2df4dac9709b4beb255b8b75 by Cristian One?. Unfortunately, > this was inadvertently disabled when BUG:311481 REVIEW:107714 was committed. > This is now fixed. > This review adds the same capability for investment transactions. > In addition, there have been requests that when clearing the memo field, it > should when required be empty rather that containing a blank character. It > is necessary to enter a character in the memo field in order to signal that > an edit has occurred, but now that character may then be deleted to leave the > field empty, if that is what is required. > With investment transactions, it is always necessary to enter the security > name as well. This requirement could probably be removed, but it is probably > sensible to be editing just a single security. > As with all editing of multiple items, all fields appear as blank initially. > This has been retained here with multiple memo editing, but if desired, this > could be changed and the field could be left showing previous content, which > could be more intuitive for a user wanting to have an empty field. > > > Diffs > ----- > > kmymoney/dialogs/investactivities.h aa4800f > kmymoney/dialogs/investactivities.cpp e4760e5 > kmymoney/dialogs/investtransactioneditor.h 20e3819 > kmymoney/dialogs/investtransactioneditor.cpp 805bd8d > kmymoney/dialogs/transactioneditor.h f07dafb > kmymoney/dialogs/transactioneditor.cpp 71d94ec > > Diff: https://git.reviewboard.kde.org/r/113427/diff/ > > > Testing > ------- > > Numerous groups of investment and checking transactions entered and edited > correctly. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
