-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113143/
-----------------------------------------------------------
(Updated Oct. 19, 2013, 4:53 p.m.)
Review request for KMymoney.
Changes
-------
In addressing the issues that followed adding the code to fix the basic
problem, the handling of check numbers that included alpha or punctuation
characters, the size of the patch grew somewhat.
For clarity, I've therefore split the patch into two, this part adding the
capability to handle non-numeric characters.
The second part will follow, which builds upon this first part, and deals with
the better handling of editing or deleting existing numbers while producing the
revised next check number.
Bugs: 319801
http://bugs.kde.org/show_bug.cgi?id=319801
Repository: kmymoney
Description
-------
If a user's sequence of check numbers is broken by, say 'ATM' or an invoice
number such as 'No 123-001 ABC', the next check number produced will be '1',
entries containing alpha or punctuation characters not being saved.
The fix corrects this by saving the complete entry, and uses any entered
numeric part to calculate the next number in sequence. If an existing numeric
entry is edited, this entry will be taken into account for the next number.
There are some quirks. If the entry which led to the current 'next number' is
deleted, it is not possible to revert to the previous, now forgotten, 'next
number', so the produced 'next number' is likely to leave a 'gap', and may need
editing. Also, there is no check that a new 'next number' does not already
exist. For instance, if there is the erroneous sequence 23,23,24, the 'next
number' will be the expected 25. However, if the user corrects the error by
changing a 23 to 22, the new 'next number' will be 23, which also already
exists. I'm not sure if such issues, which exist also in the current release,
are worthy of fixing for a fairly unimportant area, without becoming more
involved.
Diffs (updated)
-----
kmymoney/dialogs/investactivities.cpp 50f33ed
kmymoney/dialogs/investtransactioneditor.h 3e62c2a
kmymoney/dialogs/investtransactioneditor.cpp e9f87fb
kmymoney/dialogs/transactioneditor.h f07dafb
kmymoney/dialogs/transactioneditor.cpp cfb0f71
kmymoney/widgets/transactioneditorcontainer.h f77b195
Diff: http://git.reviewboard.kde.org/r/113143/diff/
Testing
-------
Many manual entries checked, including coping with all values in the unit
tests. The unit test runs OK.
Thanks,
Allan Anderson
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
