-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122364/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 12:27 a.m.)
Review request for KMymoney.
Changes
-------
Replacement patch, in place of original, with conflict fixed, having now done
the update from Master. Apologies again.
Bugs: 340656
http://bugs.kde.org/show_bug.cgi?id=340656
Repository: kmymoney
Description
-------
Fix display on high-definition monitors. Fix interaction between the import
preview table widget and the parameter entry wizard, caused by them both
resizing dynamically within the same window. This was achieved by creating a
new class and UI for the wizard and transferring most of the existing relevant
code out of the large csvdialog.cpp file into the new class and file.
Unfortunately, because 11 UIs are affected and the transfer of existing logic
into a new class, the patch is quite large, although there is little new code
involved.
Diffs
-----
kmymoney/plugins/csvimport/csvwizard.h PRE-CREATION
kmymoney/plugins/csvimport/csvwizard.cpp PRE-CREATION
kmymoney/plugins/csvimport/csvwizard.ui PRE-CREATION
kmymoney/plugins/csvimport/introwizardpage.ui 2bf93f0
kmymoney/plugins/csvimport/investmentdlg.cpp 5e7ce06
kmymoney/plugins/csvimport/investmentwizardpage.ui d3f2857
kmymoney/plugins/csvimport/investprocessing.h 3c08dee
kmymoney/plugins/csvimport/investprocessing.cpp 2b6b2d1
kmymoney/plugins/csvimport/lines-datewizardpage.ui 01d7253
kmymoney/plugins/csvimport/redefinedlgdecl.ui 26d8b62
kmymoney/plugins/csvimport/separatorwizardpage.ui 21136f2
kmymoney/plugins/csvimport/CMakeLists.txt 36e5afc
kmymoney/plugins/csvimport/bankingwizardpage.ui 9e1b5cb
kmymoney/plugins/csvimport/completionwizardpage.ui ce61e89
kmymoney/plugins/csvimport/csvdialog.h 780329d
kmymoney/plugins/csvimport/csvdialog.cpp b986317
kmymoney/plugins/csvimport/csvdialog.ui 166b04a
Diff: https://git.reviewboard.kde.org/r/122364/diff/
Testing
-------
Tested on 96 DPI and 160 DPI. Also, the OP of the bug has tested the patch and
confirms its performance.
There is one remaining UI not yet included. I've completed its testing, but as
it's a little-used window, I've held it back to avoid making this patch even
larger.
I'm unable to test on Windows.
File Attachments (updated)
----------------
Updated patch
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/6e4dad98-936c-4ca0-8804-c4abb9b51438__0002-BUG-340656.patch
Thanks,
Allan Anderson
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
