> On Sept. 18, 2014, 6:57 p.m., Cristian Oneț wrote: > > It fixes the reported problem. Don't forget to add the 'BUG: NR' and > > 'REVIEW: NR' markers in the commit message (each on it's own line).
Good. Did you notice specifically the behaviour of the radio buttons? - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120260/#review66860 ----------------------------------------------------------- On Sept. 18, 2014, 11:49 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120260/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 11:49 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > I've been working for a while on improving the appearance and operation of > the CSV importer plugin, which has gone far more slowly than I expected. > In the meantime, a new version of KMyMoney has been released for Windows, and > two users have reported the known problem of buttons at the foot of the > plugin page not appearing fully. Plus, a difficulty with the start page > radio buttons. So, there is more urgency now, and I've extracted the > reworked UI files, and made a patch which includes them, with a needed small > change to the code handling the UI. Also, there is a small fix for > occasional crashes related to decimal symbol handling. This is based on the > current HEAD. Otherwise, the UI looks much like the HEAD version, apart from > the correct visibility of the buttons. > I am still working on improving other parts of the plugin > > > Diffs > ----- > > kmymoney/plugins/csvimport/separatorwizardpage.ui 30b2dc7 > kmymoney/plugins/csvimport/csvdialog.cpp 7e0229b > kmymoney/plugins/csvimport/csvdialog.ui 36e7fd5 > kmymoney/plugins/csvimport/csvutil.h 546bfa5 > kmymoney/plugins/csvimport/csvutil.cpp 4c0dd25 > kmymoney/plugins/csvimport/introwizardpage.ui 9bd29f5 > kmymoney/plugins/csvimport/investmentwizardpage.ui 3744963 > kmymoney/plugins/csvimport/investprocessing.h 55dd4ca > kmymoney/plugins/csvimport/investprocessing.cpp c21c679 > kmymoney/plugins/csvimport/lines-datewizardpage.ui fb10a0e > kmymoney/plugins/csvimport/bankingwizardpage.ui d2179bf > kmymoney/plugins/csvimport/completionwizardpage.ui 99db075 > kmymoney/plugins/csvimport/csvdialog.h b9d4527 > > Diff: https://git.reviewboard.kde.org/r/120260/diff/ > > > Testing > ------- > > I've tested the patch on Linux Mint and Ubuntu, with a large number of > different files. > I am not able to test on Windows, having only XP. > I don't know if these changes help with the radio button issue on Windows, as > I am not able to reproduce the problem here, the radio, and all other, > buttons work as expected. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
