[Kmymoney-devel] Feature request: accounts per fiscal period

2013-01-02 Thread Oliver Maurhart
#!/bin/hi * I played around with KMyMoney yet for nearly 4 months now and I fully congratulate you for this marvelous piece of software you created! As now it is 2013, I still see the total on my account/category page whereas I would like to chose some different views based on a fiscal perio

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/ --- (Updated Jan. 2, 2013, 10:49 p.m.) Review request for KMymoney and Łukasz

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > I'll comment on the tests only, as the rest looks fine to me, including the > > screenshot! > > Marko Käning wrote: > Actually, what concerns the method hadNewerTransaction() there is a > questionable point in its design: > >

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/ --- (Updated Jan. 2, 2013, 9:20 p.m.) Review request for KMymoney and Łukasz M

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > I'll comment on the tests only, as the rest looks fine to me, including the > > screenshot! Actually, what concerns the method hadNewerTransaction() there is a questionable point in its design: The way I use it is that I make sure th

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.cpp, line 2112 > > > > > > I think that dependency on test #1 could be easily removed - that's the > > right way to go

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Łukasz Maszczyński
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.cpp, line 2112 > > > > > > I think that dependency on test #1 could be easily removed - that's the > > right way to go

Re: [Kmymoney-devel] Review Request: fix test 'kmymoney-querytabletest' wrt date formatting

2013-01-02 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108041/ --- (Updated Jan. 2, 2013, 8:47 p.m.) Review request for KMymoney, Cristian On

Re: [Kmymoney-devel] Review Request: fix test 'kmymoney-querytabletest' wrt date formatting

2013-01-02 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108041/ --- (Updated Jan. 2, 2013, 8:46 p.m.) Review request for KMymoney, Cristian On

Re: [Kmymoney-devel] Review Request: fix test 'kmymoney-querytabletest' wrt date formatting

2013-01-02 Thread Marko Käning
> On Jan. 2, 2013, 8:35 p.m., Łukasz Maszczyński wrote: > > kmymoney/reports/querytabletest.cpp, line 702 > > > > > > Use a meaningful name, e.g. midTransactionDate and colocate the > > variable with others (open

Re: [Kmymoney-devel] Review Request: fix test 'kmymoney-querytabletest' wrt date formatting

2013-01-02 Thread Łukasz Maszczyński
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108041/#review24491 --- I assume that openingDate is meant to be interpreted as the dat

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.h, line 100 > > > > > > You extracted a part of testAddAccounts() just fine, but please also > > update the original me

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Marko Käning
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.cpp, line 2112 > > > > > > I think that dependency on test #1 could be easily removed - that's the > > right way to go

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction

2013-01-02 Thread Łukasz Maszczyński
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/#review24488 --- I'll comment on the tests only, as the rest looks fine to me, i

[Kmymoney-devel] [Bug 312481] New: KMyMoney fails to compile with gmp-5.10

2013-01-02 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=312481 Bug ID: 312481 Summary: KMyMoney fails to compile with gmp-5.10 Classification: Unclassified Product: kmymoney4 Version: git master Hardware: Compiled Sources OS: other