> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > I'll comment on the tests only, as the rest looks fine to me, including the > > screenshot!
Actually, what concerns the method hadNewerTransaction() there is a questionable point in its design: The way I use it is that I make sure that the account value "lastImportedTransactionDate" exists for the account in question BEFORE I actually call the method hadNewerTransaction() to determine whether there are newer transactions after the last import. Is this acceptable or to be considered too error-prone? (Theoretically the method could be called also for an account without an account value "lastImportedTransactionDate"!) - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/#review24488 ----------------------------------------------------------- On Jan. 1, 2013, 9:13 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107619/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2013, 9:13 p.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > The homepage accounts tables now show a different icon if there are > transactions for an account after the last online transaction - highlighting > for the user the necessity to download transactions in order to verify the > account status. > > > Diffs > ----- > > kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df > kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd > kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 > kmymoney/mymoney/mymoneyfiletest.cpp > feb9d57ecd7156fc1eea189a905fa797aeae9183 > kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c > > Diff: http://git.reviewboard.kde.org/r/107619/diff/ > > > Testing > ------- > > Built and ran application and test cases successfully. > > > Screenshots > ----------- > > example for the 4 possible cases of online status > http://git.reviewboard.kde.org/r/107619/s/948/ > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
