> On Jan. 2, 2013, 8:35 p.m., Łukasz Maszczyński wrote: > > kmymoney/reports/querytabletest.cpp, line 702 > > <http://git.reviewboard.kde.org/r/108041/diff/1/?file=103283#file103283line702> > > > > Use a meaningful name, e.g. midTransactionDate and colocate the > > variable with others (openingDate, closingDate) for better readability
I haven't figured out yet where actually this intermediate date is created, merely just saw the result in the HTML files created by the test, which is why I had just called it "tempDate" for now. - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108041/#review24491 ----------------------------------------------------------- On Jan. 2, 2013, 1:31 a.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108041/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2013, 1:31 a.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > Fixes test 'kmymoney-querytabletest' w.r.t. its date formatting. > > > Diffs > ----- > > kmymoney/reports/querytabletest.cpp > 03f7a1a547cf311af907b053d49592663952a3bf > > Diff: http://git.reviewboard.kde.org/r/108041/diff/ > > > Testing > ------- > > Build and ran test #28 successfully. > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
