----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108041/#review24491 -----------------------------------------------------------
I assume that openingDate is meant to be interpreted as the date of the first transaction and closingDate - the last transaction in the table. But this assumption needs to be confirmed - Thomas, Cristian, Alvaro? kmymoney/reports/querytabletest.cpp <http://git.reviewboard.kde.org/r/108041/#comment18811> Use a meaningful name, e.g. midTransactionDate and colocate the variable with others (openingDate, closingDate) for better readability - Łukasz Maszczyński On Jan. 2, 2013, 1:31 a.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108041/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2013, 1:31 a.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > Fixes test 'kmymoney-querytabletest' w.r.t. its date formatting. > > > Diffs > ----- > > kmymoney/reports/querytabletest.cpp > 03f7a1a547cf311af907b053d49592663952a3bf > > Diff: http://git.reviewboard.kde.org/r/108041/diff/ > > > Testing > ------- > > Build and ran test #28 successfully. > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
