> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.cpp, line 2112 > > <http://git.reviewboard.kde.org/r/107619/diff/5/?file=103701#file103701line2112> > > > > I think that dependency on test #1 could be easily removed - that's the > > right way to go, whenever it's possible. > > Marko Käning wrote: > So, you want me to remove this dependency? > > (If so, I'd have to duplicate the corresponding code for the 2nd test > case.) > > Łukasz Maszczyński wrote: > Yes, my suggestion is to remove this dependency. If I understand test #2 > correctly, you don't need much from #1 there - just AddOneAccount() and the > two lines of account initialization. Please correct me if I'm wrong.
Well, I do need the transaction in the try-catch-block too, only the last three code lines of #1 are not necessary for case #2. But I could strip all the QVERIFYs, because they are already tested for in #1 when we're preparing #2... (I do understand though why it's not so nice to have this dependency, since I already saw that if test #1 fails also test #2 fails at the same line of code.) - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/#review24488 ----------------------------------------------------------- On Jan. 1, 2013, 9:13 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107619/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2013, 9:13 p.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > The homepage accounts tables now show a different icon if there are > transactions for an account after the last online transaction - highlighting > for the user the necessity to download transactions in order to verify the > account status. > > > Diffs > ----- > > kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df > kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd > kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 > kmymoney/mymoney/mymoneyfiletest.cpp > feb9d57ecd7156fc1eea189a905fa797aeae9183 > kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c > > Diff: http://git.reviewboard.kde.org/r/107619/diff/ > > > Testing > ------- > > Built and ran application and test cases successfully. > > > Screenshots > ----------- > > example for the 4 possible cases of online status > http://git.reviewboard.kde.org/r/107619/s/948/ > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
