Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen merged PR #811: URL: https://github.com/apache/maven-surefire/pull/811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

elharo commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966834827 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + Review Comment: The transitive deps don't need to be declared in this pom.xml, only the

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966817630 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + + org.slf4j + slf4j-simple + 1.7.36 + test Review Comment: Ah ye

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966808539 ## maven-surefire-plugin/pom.xml: ## @@ -43,6 +43,13 @@ + Review Comment: Please see other thread on same topic. -- This is an automated m

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966808453 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + Review Comment: In this repo's deps, found `org.codehaus.plexus.logging.Logger` exis

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

slawekjaranowski commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966806087 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + + org.slf4j + slf4j-simple + 1.7.36 + test Review Comment:

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

slawekjaranowski commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966804353 ## maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java: ## @@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractM

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966803242 ## maven-surefire-plugin/pom.xml: ## @@ -43,6 +43,13 @@ + Review Comment: I wasn't sure with an initial glance, will look more deeply now.

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966803185 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + Review Comment: I wasn't sure with an initial glance, will look more deeply now.

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966802895 ## maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java: ## @@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo im

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

elharo commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966797592 ## maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java: ## @@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo implem

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966796512 ## maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java: ## @@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo im

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

elharo commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966794558 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + Review Comment: Is there a plexus logging dependency we can remove yet? ## ma

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

elharo commented on PR #811: URL: https://github.com/apache/maven-surefire/pull/811#issuecomment-2676884411 We did indeed used to use field injection. However, we've been moving to constructor injection as part of the move from Plexus to Guice, and in general (not just Maven) constructor in

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966776941 ## maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java: ## @@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo im

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

slawekjaranowski commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966705722 ## maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java: ## @@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractM

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966555096 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + + org.slf4j + slf4j-simple + 2.0.16 Review Comment: Changed slf4j-sim

Re: [PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

slawekjaranowski commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966552021 ## maven-failsafe-plugin/pom.xml: ## @@ -45,6 +45,13 @@ + + org.slf4j + slf4j-simple + 2.0.16 Review Comment: Please use

[PR] [SUREFIRE-2291] Change logger from Plexus to SLF4J [maven-surefire]

jeffjensen opened a new pull request, #811: URL: https://github.com/apache/maven-surefire/pull/811 * Replace org.codehaus.plexus.logging.Logger with org.slf4j.Logger. * Change from injected Plexus logger to lookup SLF4J logger. Following this checklist to help us incorporate your