jeffjensen commented on code in PR #811:
URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966796512
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java:
##########
@@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo implements
SurefireReportParameters
private volatile PluginConsoleLogger consoleLogger;
- @Inject
+ public VerifyMojo() {
+ this.logger = LoggerFactory.getLogger(getClass());
Review Comment:
Yes, the Plexus logger was a component, so injecting was the way. SLF4J is
not, so agreed, Loggers this way are looked up with LoggerFactory and almost
always on field initialization.
I found a couple of cases in these updates that tests set a mocked logger
for verification, so kept that constructor and added a noargs constructor to
instantiate it. This balances the testing need and prod code need and
minimizes instances/no temp objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
