elharo commented on code in PR #811:
URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966797592
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java:
##########
@@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo implements
SurefireReportParameters
private volatile PluginConsoleLogger consoleLogger;
- @Inject
+ public VerifyMojo() {
+ this.logger = LoggerFactory.getLogger(getClass());
Review Comment:
Now that you mention it, logging for verification makes me feel a bit icky.
This feels like one mistake (injecting loggers) being used to duct tape over
another mistake (unit tests that use loggers to inspect code). We should
probably fix it at the root by not asserting on logger messages at all.
However, that's a separate fix that shouldn't be included in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
