slawekjaranowski commented on code in PR #811: URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966806087
########## maven-failsafe-plugin/pom.xml: ########## @@ -45,6 +45,13 @@ </properties> <dependencies> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-simple</artifactId> + <version>1.7.36</version> + <scope>test</scope> Review Comment: We declare `slf4j-simple` in scope test but we used `slf4j-api` from transitive dependencies in production code. I would like to add also `slf4j-api` in standard compile scope. W can also add version in root pom in dependencies management instead of define version in each module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
