elharo commented on code in PR #811:
URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966794558
##########
maven-failsafe-plugin/pom.xml:
##########
@@ -45,6 +45,13 @@
</properties>
<dependencies>
+ <dependency>
Review Comment:
Is there a plexus logging dependency we can remove yet?
##########
maven-surefire-plugin/pom.xml:
##########
@@ -43,6 +43,13 @@
</properties>
<dependencies>
+ <dependency>
Review Comment:
Is there a plexus dependency we can remove here now?
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java:
##########
@@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo implements
SurefireReportParameters
private volatile PluginConsoleLogger consoleLogger;
- @Inject
+ public VerifyMojo() {
+ this.logger = LoggerFactory.getLogger(getClass());
Review Comment:
We did indeed used to use field injection. However, we've been moving to
constructor injection as part of the move from Plexus to Guice, and in general
(not just Maven) constructor injection is preferred for safety. Perhaps loggers
are a special case, but I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
