Re: [I] Using Google Java Conventions XML Config causes failure [maven-checkstyle-plugin]

schl3sch closed issue #176: Using Google Java Conventions XML Config causes failure URL: https://github.com/apache/maven-checkstyle-plugin/issues/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Using Google Java Conventions XML Config causes failure [maven-checkstyle-plugin]

schl3sch commented on issue #176: URL: https://github.com/apache/maven-checkstyle-plugin/issues/176#issuecomment-2889599041 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Bump org.xmlunit:xmlunit-core from 2.10.0 to 2.10.1 [maven-release]

dependabot[bot] opened a new pull request, #242: URL: https://github.com/apache/maven-release/pull/242 Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.10.0 to 2.10.1. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases";>org.xmlunit:xm

[PR] Bump resolverVersion from 2.0.8 to 2.0.9 [maven]

dependabot[bot] opened a new pull request, #2351: URL: https://github.com/apache/maven/pull/2351 Bumps `resolverVersion` from 2.0.8 to 2.0.9. Updates `org.apache.maven.resolver:maven-resolver-api` from 2.0.8 to 2.0.9 Commits https://github.com/apache/maven-resolver/commit/13e

[PR] Bump org.apache.maven.resolver:maven-resolver-api from 2.0.8 to 2.0.9 [maven-install-plugin]

dependabot[bot] opened a new pull request, #347: URL: https://github.com/apache/maven-install-plugin/pull/347 Bumps [org.apache.maven.resolver:maven-resolver-api](https://github.com/apache/maven-resolver) from 2.0.8 to 2.0.9. Commits https://github.com/apache/maven-resolver/co

Re: [PR] [SUREFIRE-2298] fix xml output with junit 5 nested classes [maven-surefire]

olamy commented on PR #828: URL: https://github.com/apache/maven-surefire/pull/828#issuecomment-2889266625 > Hi @olamy > > > you might be able to see progress there #828 > > But... is there any? yup sorry been busy with other stuff. I'm thinking of possible quick f

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094636980 ## .pmd/exclude.properties: ## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifac

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094636770 ## .pmd/exclude.properties: ## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifac

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094538646 ## .pmd/exclude.properties: ## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifac

[PR] Unused assignment [maven]

Pankraz76 opened a new pull request, #2350: URL: https://github.com/apache/maven/pull/2350 - https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#unnecessaryfullyqualifiedname - https://github.com/apache/maven/pull/2331 - UnusedAssignment https://github.com/user-attachments/a

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne [maven]

gastaldi commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2889224264 > Please enlighten us about Quarkus perspective on this. Thanks. @gsmet may know more about this subject -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne [maven]

Pankraz76 commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2889223225 @gastaldi I think we talked about using rewrite. FYI: consider license. What do you say about it, as quarkus leverages rewrite? Please enlighten us about Quarkus perspective on this

Re: [PR] UnnecessaryFullyQualifiedName [maven]

Pankraz76 commented on code in PR #2348: URL: https://github.com/apache/maven/pull/2348#discussion_r2094628533 ## src/graph/ReactorGraph.java: ## @@ -31,7 +31,6 @@ import java.io.IOException; import java.nio.file.Files; import java.nio.file.Paths; -import java.util.*; Review

[PR] UnnecessaryParentheses [maven]

Pankraz76 opened a new pull request, #2349: URL: https://github.com/apache/maven/pull/2349 - https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#unnecessaryfullyqualifiedname - https://github.com/apache/maven/pull/2331 - UselessParentheses (37) - https://github.com/user-atta

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094624610 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094622088 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094622088 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094622078 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094620239 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -68,6 +68,22 @@ @Singleton public class DefaultDependencyResolver impleme

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094619188 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094617144 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094617028 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094616566 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -191,18 +210,14 @@ public DependencyResolverResult resolve(DependencyRe

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094616118 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094614884 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

cstamas commented on code in PR #2311: URL: https://github.com/apache/maven/pull/2311#discussion_r2094613265 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -142,7 +142,7 @@ private String validateOutput(boolean shave, ByteA

Re: [PR] Parameter 'request' is never used [maven]

Pankraz76 closed pull request #2338: Parameter 'request' is never used URL: https://github.com/apache/maven/pull/2338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [RSPEC-S1068] Remove `unused` private fields [maven]

Pankraz76 closed pull request #2317: [RSPEC-S1068] Remove `unused` private fields URL: https://github.com/apache/maven/pull/2317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] UnnecessaryFullyQualifiedName [maven]

Pankraz76 opened a new pull request, #2348: URL: https://github.com/apache/maven/pull/2348 - https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#unnecessaryfullyqualifiedname - https://github.com/apache/maven/pull/2331 -- This is an automated message from the Apache Git Service. To

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094608333 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -191,18 +210,14 @@ public DependencyResolverResult resolve(DependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094608101 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094606089 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094606407 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094606089 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094596195 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -107,14 +127,14 @@ public class DefaultDependencyResolverResult im

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094595800 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -126,7 +141,11 @@ public DependencyResolverResult collect(@Nonnull Depe

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094595083 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -97,6 +99,24 @@ public class DefaultDependencyResolverResult imple

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094594605 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -97,6 +99,24 @@ public class DefaultDependencyResolverResult imple

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094594453 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094591899 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResol

Re: [PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

Pankraz76 commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094587418 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

Pankraz76 commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094586682 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult imple

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

Pankraz76 commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094518427 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult imple

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

desruisseaux commented on PR #2219: URL: https://github.com/apache/maven/pull/2219#issuecomment-2889112320 I think that the `DefaultDependencyResolverResult` constructor is creating some confusion. I created a new pull request that I propose as an alternative to this one: #2347. For seeing

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

desruisseaux commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094581944 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult im

[PR] [MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor [maven]

desruisseaux opened a new pull request, #2347: URL: https://github.com/apache/maven/pull/2347 This is an alternative to pull request #2219 resolving the same issue, but with more emphasis that `PathModularizationCache` should not be created in the `DefaultDependencyResolverResult` construct

[PR] [MNG-5913] Allow defining aliases for existing server configurations in settings.xml [maven]

slawekjaranowski opened a new pull request, #2346: URL: https://github.com/apache/maven/pull/2346 Add the next tag ids to the server in settings.xml Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Set

[jira] [Comment Edited] (MNG-5913) Allow to define aliases for existing server configurations in settings.xml

[ https://issues.apache.org/jira/browse/MNG-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952456#comment-17952456 ] Michael Osipov edited comment on MNG-5913 at 5/18/25 3:21 PM: --

[jira] [Commented] (MNG-5913) Allow to define aliases for existing server configurations in settings.xml

[ https://issues.apache.org/jira/browse/MNG-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952456#comment-17952456 ] Michael Osipov commented on MNG-5913: - I am fine with that. I prefer reliability over f

[jira] [Commented] (MNG-5913) Allow to define aliases for existing server configurations in settings.xml

[ https://issues.apache.org/jira/browse/MNG-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952455#comment-17952455 ] Slawomir Jaranowski commented on MNG-5913: -- {quote} 3.9.10 has already so many tic

[I] Support Checkstyle 10.22.0 [maven-checkstyle-plugin]

BaumiCoder opened a new issue, #177: URL: https://github.com/apache/maven-checkstyle-plugin/issues/177 ### New feature, improvement proposal There were breaking changes in CheckStyle 10.22.0. From the [Release nodes](https://checkstyle.org/releasenotes.html#Release_10.22.0): >

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne [maven]

elharo commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2889040705 This is nothing new and nothing I haven't heard before. This same thing happened with MongoDB and with other projects. A proprietary closed license wasn't the right response then and it

[jira] [Commented] (MNG-5913) Allow to define aliases for existing server configurations in settings.xml

[ https://issues.apache.org/jira/browse/MNG-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952453#comment-17952453 ] Michael Osipov commented on MNG-5913: - 3.9.10 has already so many tickets and this is a

[jira] [Updated] (MNG-5913) Allow to define aliases for existing server configurations in settings.xml

[ https://issues.apache.org/jira/browse/MNG-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-5913: - Fix Version/s: 3.9.10 4.0.0-rc-4 > Allow to define aliases for existing

[jira] [Updated] (MNG-8186) Introduce flag for warning when an aggregator mojo is locking other mojo executions

[ https://issues.apache.org/jira/browse/MNG-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-8186: - Fix Version/s: 3.9.x-candidate 4.0.x-candidate (wa

[jira] [Commented] (MNG-8186) Introduce flag for warning when an aggregator mojo is locking other mojo executions

[ https://issues.apache.org/jira/browse/MNG-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952452#comment-17952452 ] Slawomir Jaranowski commented on MNG-8186: -- As mentioned in linked issue it affect

Re: [PR] extract common functionality of DefaultPluginXmlFactory [maven]

gnodet commented on code in PR #2326: URL: https://github.com/apache/maven/pull/2326#discussion_r2094547990 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -38,65 +37,63 @@ import org.apache.maven.plugin.descriptor.io.PluginDescriptorS

[jira] [Comment Edited] (MNG-8711) "Duplicate artifact" in LifecycleDependencyResolver

[ https://issues.apache.org/jira/browse/MNG-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948209#comment-17948209 ] Vasilii Gulevich edited comment on MNG-8711 at 5/18/25 2:50 PM: -

[jira] [Assigned] (MNG-8711) "Duplicate artifact" in LifecycleDependencyResolver

[ https://issues.apache.org/jira/browse/MNG-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MNG-8711: Assignee: Slawomir Jaranowski > "Duplicate artifact" in LifecycleDependencyResolver

Re: [PR] First iteration: Page about Maven DI [maven-site]

gnodet commented on code in PR #648: URL: https://github.com/apache/maven-site/pull/648#discussion_r2094466616 ## content/markdown/maven-di.md: ## @@ -0,0 +1,322 @@ + + +# Maven DI + +## What is Maven DI? + +Maven DI is the dependency injection framework of Maven, that is introd

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094539384 ## pom.xml: ## @@ -799,17 +799,39 @@ under the License. org.apache.maven.plugins maven-pmd-plugin Review Comment: its already there,

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094539384 ## pom.xml: ## @@ -799,17 +799,39 @@ under the License. org.apache.maven.plugins maven-pmd-plugin Review Comment: its already there,

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094541415 ## pom.xml: ## @@ -1170,5 +1193,19 @@ under the License. + + pmd + +true Review Comment: this is not working, why? on

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094541182 ## pom.xml: ## @@ -1170,5 +1193,19 @@ under the License. + + pmd Review Comment: Spot is configured in parent so how to do here? Pr

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094539384 ## pom.xml: ## @@ -799,17 +799,39 @@ under the License. org.apache.maven.plugins maven-pmd-plugin Review Comment: its already there.

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne [maven]

timtebeek commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2889017421 I've spoken at length with the author linked above at Code Remix Summit last week, helped him understand and analyze the changes, and got him set up to continue his work. Despite this he

Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Best Practices [maven]

Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094538646 ## .pmd/exclude.properties: ## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifac

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

Pankraz76 commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094518296 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult imple

Re: [I] `Could not acquire write lock for…` errors [maven-mvnd]

kah-ell commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-2888995039 Also seems to happen on Linux. Happened while downloading dependencies from the command: ```

Re: [PR] First iteration: Page about Maven DI [maven-site]

sparsick commented on code in PR #648: URL: https://github.com/apache/maven-site/pull/648#discussion_r2094522215 ## content/markdown/maven-di.md: ## @@ -0,0 +1,322 @@ + + +# Maven DI + +## What is Maven DI? + +Maven DI is the dependency injection framework of Maven, that is intr

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

Pankraz76 commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094518296 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult imple

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

Pankraz76 commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094518296 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult imple

Re: [PR] [MNG-8696] PathModularizationCache needs to set cache [maven]

Pankraz76 commented on code in PR #2219: URL: https://github.com/apache/maven/pull/2219#discussion_r2094518198 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ## @@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult imple

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

Pankraz76 commented on code in PR #2311: URL: https://github.com/apache/maven/pull/2311#discussion_r2094517485 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -142,7 +142,7 @@ private String validateOutput(boolean shave, Byt

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

Pankraz76 commented on code in PR #2311: URL: https://github.com/apache/maven/pull/2311#discussion_r2094517485 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -142,7 +142,7 @@ private String validateOutput(boolean shave, Byt

Re: [PR] make fields of DefaultSettingsBuilder final [maven]

Pankraz76 closed pull request #2339: make fields of DefaultSettingsBuilder final URL: https://github.com/apache/maven/pull/2339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Support --no-fonts option [maven-javadoc-plugin]

joakime commented on issue #369: URL: https://github.com/apache/maven-javadoc-plugin/issues/369#issuecomment-2888969284 Since the `maven-javadoc-plugin` has different goals. I would like to propose that the default is to _not use fonts_ when a `jar` goal is used. * javadoc:jar

Re: [I] Support --no-fonts option [maven-javadoc-plugin]

olamy commented on issue #369: URL: https://github.com/apache/maven-javadoc-plugin/issues/369#issuecomment-2888967408 Could be eventually default for javadoc jar for jdk23+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] First iteration: Page about Maven DI [maven-site]

cstamas commented on PR #648: URL: https://github.com/apache/maven-site/pull/648#issuecomment-2888966466 Folks: Maven DI != Sisu, is completely new and contained in Maven 4 and uses Maven specific annotations and index as well. -- This is an automated message from the Apache Git Servic

Re: [PR] First iteration: Page about Maven DI [maven-site]

cstamas commented on code in PR #648: URL: https://github.com/apache/maven-site/pull/648#discussion_r2094511831 ## content/markdown/maven-di.md: ## @@ -0,0 +1,322 @@ + + +# Maven DI + +## What is Maven DI? + +Maven DI is the dependency injection framework of Maven, that is intro

Re: [PR] [SUREFIRE-2298] fix xml output with junit 5 nested classes [maven-surefire]

pzygielo commented on PR #828: URL: https://github.com/apache/maven-surefire/pull/828#issuecomment-2888961329 Hi @olamy > you might be able to see progress there https://github.com/apache/maven-surefire/pull/828 But... is there any? -- This is an automated message from the

Re: [I] Support --no-fonts option [maven-javadoc-plugin]

joakime commented on issue #369: URL: https://github.com/apache/maven-javadoc-plugin/issues/369#issuecomment-2888953110 On large projects, like Eclipse Jetty, a release with JDK23 adds 1.0GB of extra content to the repository, simply due to the inclusion of these extra fonts. IMO, i

Re: [I] link to "Guide to Using Toolchains" broken [maven-site]

michael-o commented on issue #780: URL: https://github.com/apache/maven-site/issues/780#issuecomment-294027 Found it: `org.apache.maven.doxia.site.inheritance.DefaultSiteModelInheritanceAssembler.relativizeLink(String, String)` which calls `org.apache.maven.doxia.site.inheritance.U

Re: [PR] First iteration: Page about Maven DI [maven-site]

olamy commented on code in PR #648: URL: https://github.com/apache/maven-site/pull/648#discussion_r2094459552 ## content/markdown/maven-di.md: ## @@ -0,0 +1,322 @@ + + +# Maven DI + +## What is Maven DI? + +Maven DI is the dependency injection framework of Maven, that is introdu

Re: [PR] First iteration: Page about Maven DI [maven-site]

sparsick commented on PR #648: URL: https://github.com/apache/maven-site/pull/648#issuecomment-282567 @gnodet is this okay for the first iteration for a page about Maven DI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [MNG-8731] Use https for xsi:schemaLocation in generated descriptors [maven]

slawekjaranowski merged PR #2341: URL: https://github.com/apache/maven/pull/2341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

[jira] [Created] (MNG-8731) Use https for xsi:schemaLocation in generated descriptors

Slawomir Jaranowski created MNG-8731: Summary: Use https for xsi:schemaLocation in generated descriptors Key: MNG-8731 URL: https://issues.apache.org/jira/browse/MNG-8731 Project: Maven I

Re: [I] Generate pmd.xml, but skip HTML generation [maven-pmd-plugin]

slawekjaranowski commented on issue #189: URL: https://github.com/apache/maven-pmd-plugin/issues/189#issuecomment-271795 Mojo classes should be refactored, currently we have, like: ```java @Mojo(name = "check", defaultPhase = LifecyclePhase.VERIFY, threadSafe = true) @Execu

Re: [I] link to "Guide to Using Toolchains" broken [maven-site]

michael-o commented on issue #780: URL: https://github.com/apache/maven-site/issues/780#issuecomment-244938 Checking... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.