Pankraz76 commented on code in PR #2311:
URL: https://github.com/apache/maven/pull/2311#discussion_r2094517485
##########
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##########
@@ -142,7 +142,7 @@ private String validateOutput(boolean shave,
ByteArrayOutputStream stdout, ByteA
}
// sanity checks: stderr has any OR result is empty string (no method
should emit empty string)
if (stderr.size() > 0 || result.trim().isEmpty()) {
- throw new ExecutorException(
+ System.err.println(
Review Comment:
do we have logger for this? using system directly would cause spotbugs
violations. We having this code the pattern a lot so its a bigger thing kind of.
https://stackoverflow.com/questions/8601831/do-not-use-system-out-println-in-server-side-code#:~:text=71-,System.,until%20the%20println%20has%20finished.
Why cannot we throw anymore, please? Of course we dont want to lose the
information. As we having error we can not tread, how and why continue?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
