desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094594605
########## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java: ########## @@ -97,6 +99,24 @@ public class DefaultDependencyResolverResult implements DependencyResolverResult */ private final PathModularizationCache cache; + /** + * Creates an initially empty result with a temporary cache. + * Callers should add path elements by calls to {@link #addDependency(Node, Dependency, Predicate, Path)}. + * + * <p><b>WARNING: this constructor may be removed in a future Maven release.</b> + * The reason is because {@code DefaultDependencyResolverResult} needs a cache, which should + * preferably by session-wide. But we have not yet clarified how such caches should be managed.</p> Review Comment: Thanks, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org