Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2094636980
########## .pmd/exclude.properties: ########## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifactFilterManager=MissingOverride +org.apache.maven.DefaultMaven=GuardLogStatement +org.apache.maven.DefaultProjectDependenciesResolver=MissingOverride +org.apache.maven.MavenArtifactTypeRegistry=MissingOverride +org.apache.maven.ReactorReader=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.RepositoryUtils=ForLoopVariableCount +org.apache.maven.api.ChildrenPointer=MissingOverride +org.apache.maven.api.DefaultExtensibleEnum=MissingOverride +org.apache.maven.api.DefaultPathScope=UseEnumCollections +org.apache.maven.api.DependenciesPointer=MissingOverride +org.apache.maven.api.DependencyScope=UnnecessaryFullyQualifiedName +org.apache.maven.api.ExtensibleEnums=AbstractClassWithoutAbstractMethod +org.apache.maven.api.JavaPathType=UnnecessaryModifier,UnnecessaryFullyQualifiedName +org.apache.maven.api.Language=ConstantsInInterface +org.apache.maven.api.MonotonicClock=UnnecessaryFullyQualifiedName +org.apache.maven.api.Packaging=MissingOverride +org.apache.maven.api.PhasePointer=MissingOverride +org.apache.maven.api.ProjectScope=ConstantsInInterface +org.apache.maven.api.Type=MissingOverride +org.apache.maven.api.Version=MissingOverride +org.apache.maven.api.VersionConstraint=MissingOverride +org.apache.maven.api.VersionRange=MissingOverride +org.apache.maven.api.cli.mvn.MavenOptions=MissingOverride +org.apache.maven.api.cli.mvnenc.EncryptOptions=MissingOverride +org.apache.maven.api.cli.mvnsh.ShellOptions=MissingOverride +org.apache.maven.api.model.InputLocation=MissingOverride +org.apache.maven.api.plugin.testing.Foo=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements,UseVarargs +org.apache.maven.api.plugin.testing.stubs.PluginStub=MissingOverride +org.apache.maven.api.plugin.testing.stubs.RepositorySystemSupplier=LooseCoupling +org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports +org.apache.maven.api.plugin.testing.stubs.SessionStub=LooseCoupling +org.apache.maven.api.services.ArtifactCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.ArtifactFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.BaseRequest=MissingOverride +org.apache.maven.api.services.DefaultArtifactFactoryRequestArtifact=MissingOverride +org.apache.maven.api.services.DefaultDependencyCoordinatesFactoryRequest=MissingOverride +org.apache.maven.api.services.DependencyCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.MessageBuilder=UseVarargs +org.apache.maven.api.services.ModelBuilderResult=MissingOverride +org.apache.maven.api.services.xml.DefaultXmlReaderRequest=MissingOverride +org.apache.maven.api.spi.PropertyContributor=LooseCoupling +org.apache.maven.api.xml.Impl=UnusedAssignment,AvoidReassigningParameters +org.apache.maven.artifact.ArtifactStatus=MissingOverride +org.apache.maven.artifact.ArtifactUtils=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.DefaultArtifact=UselessParentheses,AvoidReassigningParameters,LiteralsFirstInComparisons +org.apache.maven.artifact.InvalidArtifactRTException=MissingOverride +org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement,MissingOverride +org.apache.maven.artifact.factory.DefaultArtifactFactory=MissingOverride +org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements,LooseCoupling +org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement,MissingOverride +org.apache.maven.artifact.manager.DefaultWagonManager=MissingOverride,AvoidReassigningLoopVariables,GuardLogStatement,AvoidReassigningParameters +org.apache.maven.artifact.metadata.AbstractArtifactMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.metadata.ArtifactMetadataSource=MissingOverride +org.apache.maven.artifact.repository.ArtifactMetadataAdapter=MissingOverride +org.apache.maven.artifact.repository.ArtifactRepositoryAdapter=MissingOverride +org.apache.maven.artifact.repository.ArtifactRepositoryPolicy=UnnecessaryFullyQualifiedName,AvoidReassigningParameters +org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter,AvoidReassigningParameters,MissingOverride +org.apache.maven.artifact.repository.DefaultArtifactRepositoryFactory=MissingOverride,PreserveStackTrace +org.apache.maven.artifact.repository.DefaultRepositoryRequest=MissingOverride +org.apache.maven.artifact.repository.LegacyLocalRepositoryManager=AvoidReassigningParameters,MissingOverride +org.apache.maven.artifact.repository.MavenArtifactRepository=MissingOverride,LiteralsFirstInComparisons +org.apache.maven.artifact.repository.layout.DefaultRepositoryLayout=MissingOverride +org.apache.maven.artifact.repository.layout.FlatRepositoryLayout=MissingOverride +org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements,MissingOverride,GuardLogStatement +org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.MetadataBridge=MissingOverride +org.apache.maven.artifact.repository.metadata.SnapshotArtifactRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.io.DefaultMetadataReader=MissingOverride +org.apache.maven.artifact.repository.metadata.io.xpp3.MetadataXpp3Writer=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.resolver.AbstractArtifactResolutionException=ForLoopCanBeForeach +org.apache.maven.artifact.resolver.ArtifactResolutionRequest=MissingOverride +org.apache.maven.artifact.resolver.ArtifactResolutionResult=MissingOverride +org.apache.maven.artifact.resolver.CyclicDependencyException=MissingOverride +org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup,MissingOverride +org.apache.maven.artifact.resolver.DebugResolutionListener=MissingOverride,GuardLogStatement +org.apache.maven.artifact.resolver.DefaultArtifactResolver=MissingOverride,PreserveStackTrace,GuardLogStatement +org.apache.maven.artifact.resolver.DefaultResolutionErrorHandler=MissingOverride +org.apache.maven.artifact.resolver.ResolveTask=MissingOverride +org.apache.maven.artifact.resolver.WarningResolutionListener=MissingOverride +org.apache.maven.artifact.resolver.filter.AbstractScopeArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.AndArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField +org.apache.maven.artifact.resolver.filter.ExclusionSetFilter=UseVarargs,MissingOverride +org.apache.maven.artifact.resolver.filter.IncludesArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.InversionArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.OrArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.TypeArtifactFilter=UnusedAssignment,MissingOverride +org.apache.maven.artifact.versioning.BigIntegerItem=MissingOverride +org.apache.maven.artifact.versioning.CombinationItem=UnusedAssignment +org.apache.maven.artifact.versioning.ComparableVersion=UselessParentheses,LooseCoupling,AvoidReassigningParameters,AvoidReassigningLoopVariables,SystemPrintln Review Comment: - https://github.com/apache/maven/pull/2349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org