desruisseaux commented on code in PR #2347: URL: https://github.com/apache/maven/pull/2347#discussion_r2094616118
########## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java: ########## @@ -67,6 +67,21 @@ @Named @Singleton public class DefaultDependencyResolver implements DependencyResolver { + /** + * Cache of information about the modules contained in a path element. + * This cache is created when first needed. It may be never created. + * + * <p><b>TODO:</b> This field should not be in this class, because the cache should be global to the session. + * This field exists here only temporarily, until clarified where to store session-wide caches.</p> + * + * @see moduleCache() Review Comment: Side note: no need for CheckStyle, as `javac` can do this verification itself with the `-Xdoclint` option. It is not enabled in Maven maybe for historical reasons. Or maybe because we want to be able to use a `@see` tag to another module without causing build failure. The latter is the kind of problem that "multi-modules project" resolves. But this is for another day, maybe far in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org