[PR] Upgrade dependencies for ITs [maven-project-info-reports-plugin]

2025-02-21 Thread via GitHub
slawekjaranowski opened a new pull request, #101: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/101 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira

Re: [PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [maven-toolchains-plugin]

2025-02-21 Thread via GitHub
Bukama merged PR #49: URL: https://github.com/apache/maven-toolchains-plugin/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [maven-doxia-sitetools]

2025-02-21 Thread via GitHub
Bukama merged PR #193: URL: https://github.com/apache/maven-doxia-sitetools/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Simply GitHub verify action [maven-plugin-tools]

2025-02-21 Thread via GitHub
Bukama merged PR #356: URL: https://github.com/apache/maven-plugin-tools/pull/356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Add Release Drafter [maven-project-info-reports-plugin]

2025-02-21 Thread via GitHub
slawekjaranowski merged PR #99: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Simply GitHub verify action [maven-plugin-tools]

2025-02-21 Thread via GitHub
slawekjaranowski commented on code in PR #356: URL: https://github.com/apache/maven-plugin-tools/pull/356#discussion_r1966462446 ## .github/workflows/maven-verify.yml: ## @@ -26,7 +26,5 @@ jobs: name: Verify uses: apache/maven-gh-actions-shared/.github/workflows/maven

Re: [PR] A grabbag of small simplifications found by IntelliJ [maven-enforcer]

2025-02-21 Thread via GitHub
slawekjaranowski commented on code in PR #354: URL: https://github.com/apache/maven-enforcer/pull/354#discussion_r1966462172 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java: ## @@ -96,18 +96,18 @@ public void execute() throws EnforcerRuleE

[PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [maven-doxia-sitetools]

2025-02-21 Thread via GitHub
dependabot[bot] opened a new pull request, #193: URL: https://github.com/apache/maven-doxia-sitetools/pull/193 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.jun

[PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [maven-toolchains-plugin]

2025-02-21 Thread via GitHub
dependabot[bot] opened a new pull request, #49: URL: https://github.com/apache/maven-toolchains-plugin/pull/49 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.jun

Re: [PR] [MNG-8587] mvnsh navigation [maven]

2025-02-21 Thread via GitHub
cstamas commented on PR #2117: URL: https://github.com/apache/maven/pull/2117#issuecomment-2675734931 Anyone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
cstamas merged PR #2116: URL: https://github.com/apache/maven/pull/2116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] Add Maven archetype article and talk to the resources and videos [maven-site]

2025-02-21 Thread via GitHub
mthmulders commented on code in PR #697: URL: https://github.com/apache/maven-site/pull/697#discussion_r1966197146 ## content/markdown/articles.md: ## @@ -34,10 +34,11 @@ under the License. ## Videos on Maven -|

Re: [PR] A grabbag of small simplifications found by IntelliJ [maven-enforcer]

2025-02-21 Thread via GitHub
elharo commented on code in PR #354: URL: https://github.com/apache/maven-enforcer/pull/354#discussion_r1966172940 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java: ## @@ -96,18 +96,18 @@ public void execute() throws EnforcerRuleException {

Re: [PR] return not needed [maven-enforcer]

2025-02-21 Thread via GitHub
elharo merged PR #352: URL: https://github.com/apache/maven-enforcer/pull/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] Add Maven archetype article and talk to the resources and videos [maven-site]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #697: URL: https://github.com/apache/maven-site/pull/697#discussion_r1966131830 ## content/markdown/articles.md: ## @@ -34,10 +34,11 @@ under the License. ## Videos on Maven -|

Re: [PR] [MNG-8588] Add activated profiles to Project interface [maven]

2025-02-21 Thread via GitHub
Giovds commented on PR #2119: URL: https://github.com/apache/maven/pull/2119#issuecomment-2675380482 @gnodet I think it is time for weekend for me. I was adding missing tests to the `getActiveProfiles()` and ended up forgetting to add the tests for the `getInjectedProfileIds()` 🙈. I'll add

[jira] [Assigned] (SUREFIRE-2291) Switch from org.codehaus.plexus.logging.Logger to slf4j

2025-02-21 Thread Jeff Jensen (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jensen reassigned SUREFIRE-2291: - Assignee: Jeff Jensen > Switch from org.codehaus.plexus.logging.Logger to slf4j > ---

Re: [PR] A grabbag of small simplifications found by IntelliJ [maven-enforcer]

2025-02-21 Thread via GitHub
gnodet commented on code in PR #354: URL: https://github.com/apache/maven-enforcer/pull/354#discussion_r1966051942 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java: ## @@ -96,18 +96,18 @@ public void execute() throws EnforcerRuleException {

[PR] A grabbag of small simplifications found by IntelliJ [maven-enforcer]

2025-02-21 Thread via GitHub
elharo opened a new pull request, #354: URL: https://github.com/apache/maven-enforcer/pull/354 There are also some likely bugs it pulled out, but I'll check those in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add link to all commits to Vote template [maven-site]

2025-02-21 Thread via GitHub
slawekjaranowski merged PR #693: URL: https://github.com/apache/maven-site/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] [MNG-8588] Add activated profiles to Project interface [maven]

2025-02-21 Thread via GitHub
gnodet commented on PR #2119: URL: https://github.com/apache/maven/pull/2119#issuecomment-2675020553 @Giovds I see the tests are using `getActiveProfiles()` instead of `getInjectedProfileIds()`. Is that because you wanted to use that method instead ? -- This is an automated message fro

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
cstamas commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1965638585 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -350,10 +350,26 @@ protected Map populateSystemProperties(LocalContext context) {

[I] Add article and video on how Maven Archetypes Plugin work [maven-site]

2025-02-21 Thread via GitHub
Giovds opened a new issue, #698: URL: https://github.com/apache/maven-site/issues/698 ### Improvement proposal Last year, I've written an article on how Maven Archetypes work, and spoke about this on various occasions. I'd be happy to contribute the links to the external resources on

[PR] Add Maven archetype article and talk to the resources and videos [maven-site]

2025-02-21 Thread via GitHub
Giovds opened a new pull request, #697: URL: https://github.com/apache/maven-site/pull/697 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Each co

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
gnodet commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1965576998 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -350,10 +350,26 @@ protected Map populateSystemProperties(LocalContext context) {

[jira] [Created] (MNG-8588) Add a way to get the activated profiles from the Project interface

2025-02-21 Thread Giovanni van der Schelde (Jira)
Giovanni van der Schelde created MNG-8588: - Summary: Add a way to get the activated profiles from the Project interface Key: MNG-8588 URL: https://issues.apache.org/jira/browse/MNG-8588 Projec

Re: [PR] Add activated profiles to Project interface [maven]

2025-02-21 Thread via GitHub
Giovds commented on PR #2119: URL: https://github.com/apache/maven/pull/2119#issuecomment-2674654053 I'm trying to move the maven-help-plugin forward into a 4.0.0 release. It currently (3.x) uses a method to get the activated profiles from the project. This method is not yet available on th

[PR] Add activated profiles to Project interface [maven]

2025-02-21 Thread via GitHub
Giovds opened a new pull request, #2119: URL: https://github.com/apache/maven/pull/2119 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965501985 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/files/AbstractRequireFiles.java: ## @@ -93,21 +93,36 @@ private void fail(List failures) throws Enf

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965501985 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/files/AbstractRequireFiles.java: ## @@ -93,21 +93,36 @@ private void fail(List failures) throws Enf

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1965470575 ## api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java: ## @@ -30,9 +30,57 @@ public final class Constants { * * @since 3.0.0 */ -@C

Re: [PR] [MNGSITE-550] What's new in Maven 4? [maven-site]

2025-02-21 Thread via GitHub
mthmulders commented on code in PR #598: URL: https://github.com/apache/maven-site/pull/598#discussion_r1965452443 ## content/markdown/whatsnewinmaven4.md: ## @@ -0,0 +1,476 @@ + + + + What's new in Maven 4? + + + +# What's new in Maven 4? Review Comment: Pending the di

Re: [PR] [MNGSITE-550] What's new in Maven 4? [maven-site]

2025-02-21 Thread via GitHub
mthmulders commented on code in PR #598: URL: https://github.com/apache/maven-site/pull/598#discussion_r1965446022 ## content/markdown/whatsnewinmaven4.md: ## @@ -0,0 +1,476 @@ + + + + What's new in Maven 4? + + + +# What's new in Maven 4? + +Maven is over 20 years old, and

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.2 to 2.44.3 [maven-parent]

2025-02-21 Thread via GitHub
Bukama merged PR #234: URL: https://github.com/apache/maven-parent/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.2 to 2.44.3 [maven-site]

2025-02-21 Thread via GitHub
Bukama merged PR #696: URL: https://github.com/apache/maven-site/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
elharo commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965438858 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -121,11 +124,11 @@ void testFileDoesNotExistSatisfyAny()

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
elharo commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965438858 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -121,11 +124,11 @@ void testFileDoesNotExistSatisfyAny()

Re: [PR] Clarify types, extensions, and classifiers [maven-site]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #695: URL: https://github.com/apache/maven-site/pull/695#discussion_r1965436079 ## content/markdown/repositories/artifacts.md: ## @@ -115,16 +122,22 @@ Out of the box, Maven Core defines the [following "types" (handled by the same n | war

Re: [PR] [MNGSITE-453] Document default groupId of plugins. [maven-site]

2025-02-21 Thread via GitHub
elharo commented on code in PR #694: URL: https://github.com/apache/maven-site/pull/694#discussion_r1965433430 ## content/apt/guides/mini/guide-configuring-plugins.apt: ## @@ -47,7 +47,11 @@ Guide to Configuring Plug-ins {{{/ref/current/maven-model/maven.html#class_plugin}inf

Re: [PR] [MNGSITE-453] Document default groupId of plugins. [maven-site]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #694: URL: https://github.com/apache/maven-site/pull/694#discussion_r1965424372 ## content/apt/guides/mini/guide-configuring-plugins.apt: ## @@ -47,6 +47,12 @@ Guide to Configuring Plug-ins {{{/ref/current/maven-model/maven.html#class_plugin}inf

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965419596 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -121,11 +124,11 @@ void testFileDoesNotExistSatisfyAny()

[jira] [Closed] (MCOMPILER-529) Improve the docs about usage 1.8 vs. 8 for source/target

2025-02-21 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCOMPILER-529. - Fix Version/s: next-release Resolution: Fixed > Improve the docs about

[jira] [Updated] (MCOMPILER-538) Do not add target/generated-sources/annotations to the source roots

2025-02-21 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MCOMPILER-538: -- Fix Version/s: (was: waiting-for-feedback) > Do not add target/generated

Re: [PR] [MNG-8587] mvnsh navigation [maven]

2025-02-21 Thread via GitHub
cstamas commented on PR #2117: URL: https://github.com/apache/maven/pull/2117#issuecomment-2674216789 Applied proposed changes. And some explanations: * removing special handling for ".." and simplified things * we deal with 3 paths: installationDir, userDir and CWD. Former two are nev

Re: [I] plantuml plugin requires dot utiliy [maven-site]

2025-02-21 Thread via GitHub
mthmulders commented on issue #630: URL: https://github.com/apache/maven-site/issues/630#issuecomment-2674094542 It seems that a nested diagram, such as in https://github.com/apache/maven-site/blob/ef8b25ba38af63e069c47b0c4d0dbdcf6e616278/src/plantuml/multi-subproject.puml#L68 needs to have

Re: [PR] [MCOMPILER-538] Do not add target/generated-sources/annotations to the source roots [maven-compiler-plugin]

2025-02-21 Thread via GitHub
desruisseaux commented on PR #191: URL: https://github.com/apache/maven-compiler-plugin/pull/191#issuecomment-2674079945 > Should we try to add the same test to master branch? Probably. It is desirable that the master contains most of the tests of the 3.x branch. -- This is an aut