Bukama commented on code in PR #2116:
URL: https://github.com/apache/maven/pull/2116#discussion_r1965470575
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java:
##########
@@ -30,9 +30,57 @@ public final class Constants {
*
* @since 3.0.0
*/
- @Config(readOnly = true)
+ @Config(readOnly = true, source = Config.Source.SYSTEM_PROPERTIES)
public static final String MAVEN_HOME = "maven.home";
+ /**
+ * Maven version.
Review Comment:
I suggest to add small examples to the javadoc - yes with semver most of
them should be clear, but I think it helps the reader to clearly read the
difference of all properties here together.
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java:
##########
@@ -350,10 +350,26 @@ protected Map<String, String>
populateSystemProperties(LocalContext context) {
Properties buildProperties = CLIReportingUtils.getBuildProperties();
String mavenVersion =
buildProperties.getProperty(CLIReportingUtils.BUILD_VERSION_PROPERTY);
- systemProperties.setProperty("maven.version", mavenVersion);
+ systemProperties.setProperty(Constants.MAVEN_VERSION, mavenVersion);
+
+ boolean snapshot = mavenVersion.endsWith("SNAPSHOT");
Review Comment:
Is the SNAPSHOT-String somewhere globally defined or is it written over and
over again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
