Bukama commented on code in PR #695: URL: https://github.com/apache/maven-site/pull/695#discussion_r1965436079
########## content/markdown/repositories/artifacts.md: ########## @@ -115,16 +122,22 @@ Out of the box, Maven Core defines the [following "types" (handled by the same n | war | `war` | | | **any** | any | | -From the table above, we can see that if we define the dependency type as "war", we will hit the "war" handler. That will -result in using the `war` extension (which may not be obvious, as the type and extension we end up with are the same, but internally this -indirection does happen). The "test-jar" is more obvious, as it translates to the `jar` extension. Finally, the **any** -last row will be used if none of the above match. Hence in that case the "type" is used as the "extension". For example. -if the dependency type is `<type>tar.gz</type>`, the extension will also be `tar.gz`. -This table may be extended by plugins and extensions used in the build. +From the table above, you can see that if the dependency type is "war", +the extension is also `war` and the classifier is the value of the +`classifier` element (if present) or the empty string if the `classifier` element +is not present. If the type is "test-jar", the extension is +"jar" and the classifier is "tests". If the type is not one of these 11 names, then the +value of the "type" is used as the "extension". For example, if the `type` element +is `<type>tar.gz</type>`, the extension will be `tar.gz`, and the classifier will +be set by the `classifier` element. This +table may be extended by plugins and extensions used in the build. + +<!-- TODO what if an explicit classifier element conflicts with the Review Comment: I suggest, we try to find out to leave no TODOs or create and issue for the TODO instead only having one in the code, where it gets forgotten. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
