cstamas commented on PR #2117: URL: https://github.com/apache/maven/pull/2117#issuecomment-2674216789
Applied proposed changes. And some explanations: * removing special handling for ".." and simplified things * we deal with 3 paths: installationDir, userDir and CWD. Former two are never changing, latter is mutable (but only in mvnsh). * hence, installation and user made plain Path, but it shows the intent of `Function<String, Path>` now: I just wanted to prevent repeated use of `normalize()` (as user may say `-Dfoo=../../bar.xml` or alike). But given there is a handful access to installation and user, this is fine. * renamed Directory to CWD to have clear intent (and it is accessed MUST MORE than former two, hence i made here a new method `resolve(seg)` (equivalent of former function). Also, I tried to made clear how CWD is mutable, but allows transitions to existing directories ONLY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
