[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

2020-02-24 Thread GitBox
bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383260144 ## File path: lucene/core/src/java/org/apache/luc

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

2020-02-24 Thread GitBox
rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383282576 ## File path: lucene/core/src/java/org/apache/lucene/index/

[GitHub] [lucene-solr] jpountz opened a new pull request #1283: LUCENE-9246: Remove `dOff` argument from `LZ4#decompress`.

2020-02-24 Thread GitBox
jpountz opened a new pull request #1283: LUCENE-9246: Remove `dOff` argument from `LZ4#decompress`. URL: https://github.com/apache/lucene-solr/pull/1283 It is always set to 0 at call sites. This is an automated message fr

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

2020-02-24 Thread GitBox
rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383289307 ## File path: lucene/core/src/java/org/apache/lucene/index/

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

2020-02-24 Thread GitBox
rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383312415 ## File path: lucene/core/src/java/org/apache/lucene/util/

[GitHub] [lucene-solr] danmuzi commented on issue #1276: LUCENE-8954: refactor Nori analyzer

2020-02-24 Thread GitBox
danmuzi commented on issue #1276: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1276#issuecomment-590368344 Thanks for checking, @jimczi I'll merge this commit :D This is an automated m

[GitHub] [lucene-solr] danmuzi merged pull request #1276: LUCENE-8954: refactor Nori analyzer

2020-02-24 Thread GitBox
danmuzi merged pull request #1276: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1276 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] jpountz opened a new pull request #1284: LUCENE-9247: Add tests for `checkIntegrity`.

2020-02-24 Thread GitBox
jpountz opened a new pull request #1284: LUCENE-9247: Add tests for `checkIntegrity`. URL: https://github.com/apache/lucene-solr/pull/1284 This adds a test to `BaseIndexFileFormatTestCase` that the combination of opening a reader and calling `checkIntegrity` on it reads all bytes of a

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

2020-02-24 Thread GitBox
bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383351481 ## File path: lucene/core/src/java/org/apache/luc

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

2020-02-24 Thread GitBox
bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383377648 ## File path: lucene/core/src/java/org/apache/lu

[GitHub] [lucene-solr] danmuzi opened a new pull request #1285: Revert "LUCENE-8954: refactor Nori analyzer"

2020-02-24 Thread GitBox
danmuzi opened a new pull request #1285: Revert "LUCENE-8954: refactor Nori analyzer" URL: https://github.com/apache/lucene-solr/pull/1285 There is a lint error in patch. Sorry for confusing. This is an automated message f

[GitHub] [lucene-solr] danmuzi merged pull request #1285: Revert "LUCENE-8954: refactor Nori analyzer"

2020-02-24 Thread GitBox
danmuzi merged pull request #1285: Revert "LUCENE-8954: refactor Nori analyzer" URL: https://github.com/apache/lucene-solr/pull/1285 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] anshumg merged pull request #1269: SOLR-14272: Remove autoReplicaFailoverBadNodeExpiration and autoReplicaFailoverWorkLoopDelay for 9.0 as it was deprecated in 7.1

2020-02-24 Thread GitBox
anshumg merged pull request #1269: SOLR-14272: Remove autoReplicaFailoverBadNodeExpiration and autoReplicaFailoverWorkLoopDelay for 9.0 as it was deprecated in 7.1 URL: https://github.com/apache/lucene-solr/pull/1269 This i

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1286: SOLR-14279: remove CSVStrategy's deprecated setters

2020-02-24 Thread GitBox
cpoerschke opened a new pull request #1286: SOLR-14279: remove CSVStrategy's deprecated setters URL: https://github.com/apache/lucene-solr/pull/1286 https://issues.apache.org/jira/browse/SOLR-14279 This is an automated messag

[GitHub] [lucene-solr] danmuzi opened a new pull request #1287: LUCENE-8954: refactor Nori analyzer

2020-02-24 Thread GitBox
danmuzi opened a new pull request #1287: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1287 LUCENE-8954 is an issue created in August last year. (https://issues.apache.org/jira/browse/LUCENE-8954) The patch is already pushed in master branch. (#839

[GitHub] [lucene-solr] danmuzi commented on issue #1287: LUCENE-8954: refactor Nori analyzer

2020-02-24 Thread GitBox
danmuzi commented on issue #1287: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1287#issuecomment-590491692 The previous PR(https://github.com/apache/lucene-solr/pull/1276) contains the lint error about unused import statement. So I reverted it on ht

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

2020-02-24 Thread GitBox
dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r383431054 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

2020-02-24 Thread GitBox
dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r383433653 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

2020-02-24 Thread GitBox
dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r383433409 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

2020-02-24 Thread GitBox
dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r383443954 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java

[GitHub] [lucene-solr] madrob merged pull request #1217: SOLR-14223 PublicKeyHandler consumes a lot of entropy during tests

2020-02-24 Thread GitBox
madrob merged pull request #1217: SOLR-14223 PublicKeyHandler consumes a lot of entropy during tests URL: https://github.com/apache/lucene-solr/pull/1217 This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage

2020-02-24 Thread GitBox
andyvuong commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage URL: https://github.com/apache/lucene-solr/pull/1223#discussion_r383548881 ## File path: solr/core/src/java/org/apache/solr/store/shared/SharedStoreManager.java

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383526667 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383523994 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383546038 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383517461 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383499305 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383536370 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383522035 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-24 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383527391 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383740837 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockRea

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383746326 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockRea

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383748557 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockRea

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383756413 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockRea

[GitHub] [lucene-solr] bruno-roustant commented on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590780144 When a debugged thoroughly to understand what was the limitation of the approach we had (to compute the common prefix

[GitHub] [lucene-solr] bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590780144 When I debugged thoroughly to understand what was the limitation of the approach we had (to compute the common

[GitHub] [lucene-solr] bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590780144 When I debugged thoroughly to understand what was the limitation of the approach we had (to compute the common

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector

2020-02-25 Thread GitBox
jpountz commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector URL: https://github.com/apache/lucene-solr/pull/1233#discussion_r383844438 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ##

[GitHub] [lucene-solr] danmuzi commented on issue #1287: LUCENE-8954: refactor Nori analyzer

2020-02-25 Thread GitBox
danmuzi commented on issue #1287: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1287#issuecomment-590874303 Thanks @jimczi I'll check Jenkins after this PR is merged. This is an automa

[GitHub] [lucene-solr] danmuzi merged pull request #1287: LUCENE-8954: refactor Nori analyzer

2020-02-25 Thread GitBox
danmuzi merged pull request #1287: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1287 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] dsmiley closed pull request #1257: SOLR-14258: DocList should not extend DocSet

2020-02-25 Thread GitBox
dsmiley closed pull request #1257: SOLR-14258: DocList should not extend DocSet URL: https://github.com/apache/lucene-solr/pull/1257 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383990057 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
dsmiley commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383994833 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.jav

[GitHub] [lucene-solr] dsmiley removed a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
dsmiley removed a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590966953 Your explanation really helps; perhaps it should be posted on the JIRA as it really summarizes what's going on.

[GitHub] [lucene-solr] bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590780144 When I debugged thoroughly to understand what was the limitation of the approach we had (to compute the common

[GitHub] [lucene-solr] bruno-roustant commented on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590972922 I put my comment in the JIRA description. This is an

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-25 Thread GitBox
bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r384014576 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockRea

[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage

2020-02-25 Thread GitBox
andyvuong commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage URL: https://github.com/apache/lucene-solr/pull/1223#discussion_r384049286 ## File path: solr/core/src/java/org/apache/solr/store/shared/SharedStoreManager.java

[GitHub] [lucene-solr] janhoy opened a new pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-25 Thread GitBox
janhoy opened a new pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288 ...and allow multiple comma separated paths See https://issues.apache.org/jira/browse/SOLR-14281 -

[GitHub] [lucene-solr] iverase opened a new pull request #1289: LUCENE-9250: Add support for Circle2d#intersectsLine around the dateline.

2020-02-26 Thread GitBox
iverase opened a new pull request #1289: LUCENE-9250: Add support for Circle2d#intersectsLine around the dateline. URL: https://github.com/apache/lucene-solr/pull/1289 This was actually an oversight in LUCENE-8707. The original PR did support crossing over the dateline added in b59b24d but

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-26 Thread GitBox
bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r383748557 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockRea

[GitHub] [lucene-solr] bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

2020-02-26 Thread GitBox
bruno-roustant edited a comment on issue #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#issuecomment-590780144 When I debugged thoroughly to understand what was the limitation of the approach we had (to compute the common

[GitHub] [lucene-site] janhoy opened a new pull request #15: Conditionally show security warning block only if news last 60 days.

2020-02-26 Thread GitBox
janhoy opened a new pull request #15: Conditionally show security warning block only if news last 60 days. URL: https://github.com/apache/lucene-site/pull/15 SOLR-13910 followup This PR converts from static calculation in Pelican of age for last secuity news, to dynamic calculation

[GitHub] [lucene-site] janhoy commented on a change in pull request #15: Conditionally show security warning block only if news last 60 days.

2020-02-26 Thread GitBox
janhoy commented on a change in pull request #15: Conditionally show security warning block only if news last 60 days. URL: https://github.com/apache/lucene-site/pull/15#discussion_r384401449 ## File path: .editorconfig ## @@ -6,13 +6,7 @@ end_of_line = lf insert_final_ne

[GitHub] [lucene-solr] iverase opened a new pull request #1290: LUCENE-9251: Filter equal edges with different value on isEdgeFromPolygon

2020-02-26 Thread GitBox
iverase opened a new pull request #1290: LUCENE-9251: Filter equal edges with different value on isEdgeFromPolygon URL: https://github.com/apache/lucene-solr/pull/1290 See https://issues.apache.org/jira/browse/LUCENE-9251 Unfortunately, I haven't been able to produce a meaningful uni

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384498162 ## File path: solr/CHANGES.txt ## @@ -110,6 +110,9 @@ Improvements * SOLR-14114: Add W

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384499124 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -607,19 +6

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384499506 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -607,19 +6

[GitHub] [lucene-solr] romseygeek merged pull request #1239: LUCENE-9207: Don't build span queries in QueryBuilder

2020-02-26 Thread GitBox
romseygeek merged pull request #1239: LUCENE-9207: Don't build span queries in QueryBuilder URL: https://github.com/apache/lucene-solr/pull/1239 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector

2020-02-26 Thread GitBox
mikemccand commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector URL: https://github.com/apache/lucene-solr/pull/1233#discussion_r384540627 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java #

[GitHub] [lucene-solr] janhoy opened a new pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website

2020-02-26 Thread GitBox
janhoy opened a new pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website URL: https://github.com/apache/lucene-solr/pull/1291 Using new git site This is an automated message from the Apache Git Servic

[GitHub] [lucene-solr] epugh opened a new pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

2020-02-26 Thread GitBox
epugh opened a new pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292 # Description Add expressible to the list of config supported methods. # Solution updated docs

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-26 Thread GitBox
janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384806562 ## File path: solr/CHANGES.txt ## @@ -110,6 +110,9 @@ Improvements * SOLR-14114: Add WA

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-26 Thread GitBox
janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384807112 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -607,19 +60

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384809872 ## File path: solr/core/src/test/org/apache/solr/core/TestConfigSets.java ## @@ -73,11 +73,11 @@ publi

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384806326 ## File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java ## @@ -128,19 +129,23 @@ publ

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384802588 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -201,24 +198,19 @@

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384812253 ## File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java ## @@ -0,0 +1,130 @@ +/* + * Lice

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384808059 ## File path: solr/core/src/test/org/apache/solr/core/TestSolrXml.java ## @@ -118,16 +110,16 @@ public

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384803099 ## File path: solr/core/src/test/org/apache/solr/core/ResourceLoaderTest.java ## @@ -169,12 +169,13 @@

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384810901 ## File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java ## @@ -0,0 +1,130 @@ +/* + * Lice

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384811052 ## File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java ## @@ -0,0 +1,130 @@ +/* + * Lice

[GitHub] [lucene-solr] madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384804436 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -909,15 +907,9 @@ public Cor

[GitHub] [lucene-solr] madrob commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
madrob commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-591684683 Also, general comment that the scope of each commit was just about perfect and I really appreciated that as a reviewer. -

[GitHub] [lucene-solr] andyvuong opened a new pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

2020-02-26 Thread GitBox
andyvuong opened a new pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter URL: https://github.com/apache/lucene-solr/pull/1293 In shared storage, deletion from the blob store works by listing files beginning with a certain p

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384851434 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -201,24 +198,19 @

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384869359 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -909,15 +907,9 @@ public Co

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384911169 ## File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java ## @@ -128,19 +129,23 @@ pub

[GitHub] [lucene-solr] atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r384911678 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java #

[GitHub] [lucene-solr] atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r384911779 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlane.j

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-26 Thread GitBox
dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384912246 ## File path: solr/core/src/test/org/apache/solr/core/TestSolrXml.java ## @@ -118,16 +110,16 @@ publi

[GitHub] [lucene-solr] atris opened a new pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris opened a new pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294 This commit introduces a mechanism to control allocation of threads to slices planned for a query. The default implementation u

[GitHub] [lucene-solr] atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r384913995 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java

[GitHub] [lucene-solr] atris commented on issue #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris commented on issue #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#issuecomment-591781782 Superseded by #1294 This is an automated message

[GitHub] [lucene-solr] atris closed pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris closed pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214 This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene-solr] atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r384914799 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java #

[GitHub] [lucene-solr] atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-26 Thread GitBox
atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r384915037 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlane.j

[GitHub] [lucene-solr] romseygeek closed pull request #1232: LUCENE-9171: Add BoostAttribute handling to QueryBuilder

2020-02-27 Thread GitBox
romseygeek closed pull request #1232: LUCENE-9171: Add BoostAttribute handling to QueryBuilder URL: https://github.com/apache/lucene-solr/pull/1232 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] romseygeek commented on issue #1232: LUCENE-9171: Add BoostAttribute handling to QueryBuilder

2020-02-27 Thread GitBox
romseygeek commented on issue #1232: LUCENE-9171: Add BoostAttribute handling to QueryBuilder URL: https://github.com/apache/lucene-solr/pull/1232#issuecomment-591880765 This was merged as part of 663611c99c7d48dd31d53ea17644fcecd5e0fad7

[GitHub] [lucene-solr] sigram commented on issue #1265: SOLR-14252: avoid NPE in metric aggregation

2020-02-27 Thread GitBox
sigram commented on issue #1265: SOLR-14252: avoid NPE in metric aggregation URL: https://github.com/apache/lucene-solr/pull/1265#issuecomment-591927359 Part of `MetricUtilsTest.testMetrics()` doesn't pass for me - the `aggregate2` metric in compact format has different values than `aggrega

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-27 Thread GitBox
msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r385082544 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultSliceExecutionCont

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-27 Thread GitBox
msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r385082712 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultSliceExecutionCont

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-27 Thread GitBox
msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r385080416 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlan

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-27 Thread GitBox
msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r385083507 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultSliceExecutionCont

[GitHub] [lucene-solr] irvingzhang opened a new pull request #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers

2020-02-27 Thread GitBox
irvingzhang opened a new pull request #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers URL: https://github.com/apache/lucene-solr/pull/1295 `if (dist < f.distance() || results.size() < ef) { Neighbor n = new ImmutableNeighbor(e.docId(), dist);

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector

2020-02-27 Thread GitBox
msokolov commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector URL: https://github.com/apache/lucene-solr/pull/1233#discussion_r385118273 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ##

[GitHub] [lucene-solr] janhoy merged pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp

2020-02-27 Thread GitBox
janhoy merged pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp URL: https://github.com/apache/lucene-solr/pull/1288 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] msokolov closed pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector

2020-02-27 Thread GitBox
msokolov closed pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector URL: https://github.com/apache/lucene-solr/pull/1233 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] msokolov commented on issue #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector

2020-02-27 Thread GitBox
msokolov commented on issue #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector URL: https://github.com/apache/lucene-solr/pull/1233#issuecomment-591966009 pushed via command line This is an automated message fr

[GitHub] [lucene-solr] msokolov commented on issue #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers

2020-02-27 Thread GitBox
msokolov commented on issue #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers URL: https://github.com/apache/lucene-solr/pull/1295#issuecomment-591970917 I believe in practice that results. max size is always set to ef, so there shouldn't be any real issue

<    1   2   3   4   5   6   7   8   9   10   >