madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of
SolrResourceLoader
URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384806326
##########
File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java
##########
@@ -128,19 +129,23 @@ public static NodeConfig fromFile(SolrResourceLoader
loader, Path configFile, Pr
}
/** TEST-ONLY */
- public static NodeConfig fromString(SolrResourceLoader loader, String xml) {
- return fromInputStream(loader, new
ByteArrayInputStream(xml.getBytes(StandardCharsets.UTF_8)), new Properties());
+ public static NodeConfig fromString(Path solrHome, String xml) {
+ return fromInputStream(
+ solrHome,
+ new ByteArrayInputStream(xml.getBytes(StandardCharsets.UTF_8)),
+ new Properties());
}
- public static NodeConfig fromInputStream(SolrResourceLoader loader,
InputStream is, Properties substituteProps) {
+ public static NodeConfig fromInputStream(Path solrHome, InputStream is,
Properties substituteProps) {
+ SolrResourceLoader loader = new SolrResourceLoader(solrHome);
Review comment:
Does this need to be closed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
