madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of
SolrResourceLoader
URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384803099
##########
File path: solr/core/src/test/org/apache/solr/core/ResourceLoaderTest.java
##########
@@ -169,12 +169,13 @@ public void testClassLoaderLibs() throws Exception {
}
SolrResourceLoader loader = new SolrResourceLoader(tmpRoot);
+ loader.addToClassLoader(SolrResourceLoader.getURLs(lib));
- // ./lib is accessible by default
+ // check "lib/aLibFile"
assertNotNull(loader.getClassLoader().getResource("aLibFile"));
// add inidividual jars from other paths
- loader.addToClassLoader(otherLib.resolve("jar2.jar").toUri().toURL());
+
loader.addToClassLoader(Arrays.asList(otherLib.resolve("jar2.jar").toUri().toURL()));
Review comment:
nit: Collections.singletonList is a tiny bit more readable IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
