dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r383433409
########## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ########## @@ -3560,25 +3569,19 @@ private boolean doFlush(boolean applyAllDeletes) throws IOException { doBeforeFlush(); testPoint("startDoFlush"); boolean success = false; - try { + try (Closeable finalizer = acquireModificationLease()){ Review comment: nit: add a space before `{` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org