madrob commented on a change in pull request #1191: SOLR-14197 Reduce API of
SolrResourceLoader
URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384809872
##########
File path: solr/core/src/test/org/apache/solr/core/TestConfigSets.java
##########
@@ -73,11 +73,11 @@ public void testConfigSetServiceFindsConfigSets() {
CoreContainer container = null;
try {
container = setupContainer(TEST_PATH().resolve("configsets").toString());
- Path testDirectory = container.getResourceLoader().getInstancePath();
+ Path solrHome = container.solrHome;
Review comment:
For consistency, prefer `getSolrHome()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
