easyice commented on PR #13256:
URL: https://github.com/apache/lucene/pull/13256#issuecomment-2033942299
Thanks for reviewing @mikemccand !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
easyice merged PR #13256:
URL: https://github.com/apache/lucene/pull/13256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on issue #13241:
URL: https://github.com/apache/lucene/issues/13241#issuecomment-2033982972
It's true that these things can still use amounts of heap that are not
completely negligible, but I wonder if it's a good reason to preserve this
interface. Doc values too can use n
jpountz commented on PR #13255:
URL: https://github.com/apache/lucene/pull/13255#issuecomment-2033985720
Thanks for looking into this. Can you add an entry to lucene/MIGRATE.txt and
lucene/CHANGES.txt under 10.0?
Let's also wait for the discussion to settle on the linked issue as it l
jpountz commented on PR #13255:
URL: https://github.com/apache/lucene/pull/13255#issuecomment-2033991164
Separately, I wonder if removing `Accountable` on `KnnVectorsReader` would
help remove the `Accountable` on some other utility classes. For instance, it
looks like `DirectMonotonicReader
jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1549312756
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -85,6 +82,10 @@ public void disableSkipping() {
pruning = Pruning.NONE;
jpountz commented on PR #13244:
URL: https://github.com/apache/lucene/pull/13244#issuecomment-2034094094
@mikemccand I wonder if we need to create such a sophisticated benchmark. If
we could confirm that performance is not affected when the cache is hot, and
better when the cache is cold, m
dungba88 commented on issue #12543:
URL: https://github.com/apache/lucene/issues/12543#issuecomment-2034162204
Yeah we released in 9.10. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
benwtrent merged PR #13258:
URL: https://github.com/apache/lucene/pull/13258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
mikemccand commented on PR #13258:
URL: https://github.com/apache/lucene/pull/13258#issuecomment-2034363245
Super, thank you @benwtrent !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
dungba88 opened a new pull request, #13259:
URL: https://github.com/apache/lucene/pull/13259
### Description
Rename NodeHash to FSTSuffixNodeCache as NodeHash is rather an obscured name
which doesn't tell its exact functionality. I also added the class Javadoc to
explain what it is f
mikemccand commented on PR #13244:
URL: https://github.com/apache/lucene/pull/13244#issuecomment-2034496802
Yeah +1 I don't think we should block this change on sophisticated
benchmarking! If we "first do no harm" (hot case not affected), and If we can
show some improvement (or even no deg
dungba88 commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-2034501658
@mikemccand I've added the suggestion so that baby-giant FST will also be
written off-heap if they are above some threshold. Let me know if there is
other changes needed.
--
This is
vigyasharma merged PR #13202:
URL: https://github.com/apache/lucene/pull/13202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
uschindler commented on PR #13244:
URL: https://github.com/apache/lucene/pull/13244#issuecomment-2035029064
Could we still keep the NORMAL ReadAdvice constant and its mappings? We
should just change the default!
I can add a system property to make it configurable like the other MMapDi
msokolov opened a new pull request, #13260:
URL: https://github.com/apache/lucene/pull/13260
…rityQueryTestCase
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550113268
##
lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java:
##
@@ -165,6 +171,9 @@ public void testRandomFilter() throws IOException {
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550132304
##
lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java:
##
@@ -522,4 +534,20 @@ final Directory getIndexStore(V... vectors) throws
I
msokolov commented on issue #12627:
URL: https://github.com/apache/lucene/issues/12627#issuecomment-2035204303
Thanks @benwtrent I opened https://github.com/apache/lucene/pull/13260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
benwtrent commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550212263
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
uschindler commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550222475
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
shubhamvishu commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550266166
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
zacharymorn commented on code in PR #13238:
URL: https://github.com/apache/lucene/pull/13238#discussion_r1550291935
##
lucene/MIGRATE.md:
##
@@ -185,6 +185,34 @@ enum.
`IOContext#LOAD` has been replaced with `IOContext#PRELOAD`.
+### IndexSearch#search(Query, Collector) bei
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550337601
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550342370
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550345012
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550345012
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550353061
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
benwtrent commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550356555
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550361771
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
uschindler commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550379842
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550380731
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
uschindler commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550381645
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
msokolov commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550383513
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
uschindler commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550390970
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/hnsw/HnswTestUtil.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dweiss closed issue #12907: jenkins dump file traversal exceptions ("no matches
found within 1")
URL: https://github.com/apache/lucene/issues/12907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on PR #13186:
URL: https://github.com/apache/lucene/pull/13186#issuecomment-2035841822
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
37 matches
Mail list logo
