uschindler commented on code in PR #13260:
URL: https://github.com/apache/lucene/pull/13260#discussion_r1550113268
##########
lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java:
##########
@@ -165,6 +171,9 @@ public void testRandomFilter() throws IOException {
try (Directory indexStore = getIndexStore(getRandomVectors(numDocs, dim));
IndexReader reader = DirectoryReader.open(indexStore)) {
+ if (graphIsDisconnected(reader)) {
Review Comment:
I would use `assumeFalse(graphIsDisconnected(reader))` as this will also log
a short notice that the test was not executed at all.
##########
lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java:
##########
@@ -522,4 +534,20 @@ final Directory getIndexStore(V... vectors) throws
IOException {
}
return dir;
}
+
+ private boolean graphIsDisconnected(IndexReader reader) throws IOException {
Review Comment:
This looks a bit crazy.... Maybe move it to the test-util, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
